Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for KIWI lock component #4639

Closed
wants to merge 1 commit into from
Closed

Conversation

c7h
Copy link
Contributor

@c7h c7h commented Feb 11, 2018

Description:

Create new documentation for the KIWI lock component

Pull request in home-assistant (if applicable): home-assistant/home-assistant#

home-assistant/core#12304

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c7h Thank you! Looks good in general, but some minor comment for you to look at. 👍

ha_category: Lock
featured: false

ha_release: 0.63.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this to the next major release (0.66 at the time of writing this comment).

footer: true
ha_category: Lock
featured: false

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add the "KIWI Opening Door" logo to this PR?

@frenck frenck changed the title create documentation for KIWI lock component Documentation for KIWI lock component Mar 13, 2018
@frenck frenck added the new-integration This PR adds documentation for a new Home Assistant integration label Mar 13, 2018
@frenck
Copy link
Member

frenck commented Mar 23, 2018

Rebased this PR in order to fix the build.

@c7h A little reminder, could you please take a look?

@DubhAd
Copy link
Contributor

DubhAd commented May 12, 2018

I note that the linked PR was closed 10 days ago, closing this too

@c7h
Copy link
Contributor Author

c7h commented May 16, 2018

will update and create new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration This PR adds documentation for a new Home Assistant integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants