Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doorbird auth and event data updates #6231

Closed
wants to merge 9 commits into from

Conversation

oblogic7
Copy link
Contributor

@oblogic7 oblogic7 commented Sep 9, 2018

Adds token/auth config details as well as event_data details.

Description:
Update documentation to match Doorbird auth and event data changes.

Pull request in home-assistant (if applicable): home-assistant/core#16504

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follow the standards.

turbokongen and others added 9 commits September 2, 2018 10:27
Sneaky little....
The main page calls them services, here we call them features, causing confusion.
The main page calls them services, here we call them features, causing confusion.
Given that turn_on and off don't work on some, would be handy to mention that ;)
* Update deconz.markdown

Added a helper app in appdaemon for deconz events

* Update deconz.markdown

changes in variables
…n-patch-2

Clarify and make sure users add config entry.
Adds token/auth config details as well as event_data details.
@ghost ghost added the to-do label Sep 9, 2018
@frenck frenck added in-progress This PR/Issue is currently being worked on has-parent This PR has a parent PR in a other repo needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch new-feature This PR adds documentation for a new Home Assistant feature to an existing integration and removed to-do labels Sep 9, 2018
@frenck
Copy link
Member

frenck commented Sep 9, 2018

@oblogic7 The PR is targeted against an incorrect base. It depends on a parent PR to be released in a next release. Therefore this PR should go to the next branch.

Please change the target and rebase if needed.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update as per above comment.

@oblogic7 oblogic7 changed the base branch from current to next September 9, 2018 18:10
@oblogic7
Copy link
Contributor Author

oblogic7 commented Sep 9, 2018

Looks like I pushed an incorrect branch. Gonna close this one and submit a new PR.

@oblogic7 oblogic7 closed this Sep 9, 2018
@ghost ghost removed the in-progress This PR/Issue is currently being worked on label Sep 9, 2018
@oblogic7 oblogic7 changed the base branch from next to current September 9, 2018 22:20
@oblogic7 oblogic7 changed the base branch from current to next September 9, 2018 22:20
@oblogic7 oblogic7 mentioned this pull request Sep 9, 2018
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-parent This PR has a parent PR in a other repo needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch new-feature This PR adds documentation for a new Home Assistant feature to an existing integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants