Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc for Opple light #6328

Merged
merged 4 commits into from Sep 26, 2018
Merged

Conversation

jedmeng
Copy link
Contributor

@jedmeng jedmeng commented Sep 21, 2018

Description:

Pull request in home-assistant (if applicable): home-assistant/core#16765

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follow the standards.

@ghost ghost added the to-do label Sep 21, 2018
@frenck frenck added new-integration This PR adds documentation for a new Home Assistant integration ready-for-review This PR needs to be reviewed next This PR goes into the next branch has-parent This PR has a parent PR in a other repo and removed to-do labels Sep 21, 2018
footer: true
logo: opple.png
ha_category: Light
ha_release: 0.79
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"0.80"


The `opple` light platform allows you to control the state of your Opple smart light.

Support all opple light with WIFI support or can be controlled by App.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The platform supports all Opple lights with Wi-Fi support or lights that can be controlled by the App.

description: The name to use when displaying this light.
required: false
type: string
default: opple Light
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opple light

@jedmeng jedmeng closed this Sep 26, 2018
@jedmeng jedmeng deleted the opple-platform branch September 26, 2018 01:55
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Sep 26, 2018
@jedmeng jedmeng restored the opple-platform branch September 26, 2018 02:06
@jedmeng jedmeng reopened this Sep 26, 2018
@ghost ghost added the to-do label Sep 26, 2018
footer: true
logo: opple.png
ha_category: Light
ha_release: 0.80
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please quote 0.80. Otherwise it will turn out as 0.8.


e.g.

![demo](https://img.alicdn.com/imgextra/i2/138006397/TB2mgp_XSOI.eBjSspmXXatOVXa_!!138006397.jpg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These images take a while to load. Maybe we should just add a link to the corresponding Opple products instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked their official website and found that there was no relevant page for product introduction. Let me just delete this for the moment.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit c381fbf into home-assistant:next Sep 26, 2018
@ghost ghost removed the to-do label Sep 26, 2018
@jedmeng jedmeng deleted the opple-platform branch September 26, 2018 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-parent This PR has a parent PR in a other repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants