Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs of knx climate component #7936

Conversation

marvin-w
Copy link
Contributor

@marvin-w marvin-w commented Dec 23, 2018

Description:

Update the KNX docs to reflect the real docs. These changes were not released yet thus the original PR of this documentation was wrong. Since I'd like to open a PR against next for the real changes this will only revert those changes from my PR. Sorry again.

The original PR that was merged accidentially was #7899.

The PR that adds the "real" documentation is #7937.

The actual feature implementation is done here: home-assistant/core#19546

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@ghost ghost added the to-do label Dec 23, 2018
@frenck
Copy link
Member

frenck commented Dec 27, 2018

@marvin-w Would you be so kind to provide a better overview of the story so far? I'm not really able to judge at this point if this PR is save to merge or not.

E.g. links to PR of stuff that should not have been merged and links to the PR that actually implement this would really be helpful.

@frenck frenck added enhancement ready-for-review This PR needs to be reviewed current This PR goes into the current branch and removed to-do labels Dec 27, 2018
@marvin-w
Copy link
Contributor Author

@frenck I added the links in the description of the PR.

@marvin-w
Copy link
Contributor Author

marvin-w commented Jan 1, 2019

Closing this as it was already merged to next.

@marvin-w marvin-w closed this Jan 1, 2019
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Jan 1, 2019
@marvin-w marvin-w deleted the feature/fix-wrongly-pushed-docs branch January 1, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current This PR goes into the current branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants