Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Owlet Component Documentation #8217

Closed
wants to merge 12 commits into from
Closed

Conversation

oblogic7
Copy link
Contributor

@oblogic7 oblogic7 commented Jan 20, 2019

Description:
Add documentation for Owlet component

Pull request in home-assistant (if applicable): home-assistant/core#20258

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@ghost ghost added the to-do label Jan 20, 2019
@rohankapoorcom rohankapoorcom added new-integration This PR adds documentation for a new Home Assistant integration has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Jan 20, 2019
@rohankapoorcom rohankapoorcom added the ready-for-review This PR needs to be reviewed label Jan 21, 2019
Copy link
Member

@rohankapoorcom rohankapoorcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logo is not working. See: https://deploy-preview-8217--home-assistant-docs.netlify.com/components/owlet/

I think you have to use a png, not an svg.

@oblogic7
Copy link
Contributor Author

Looks like I didn't get the file into the supported_brands folder when I dropped it onto the project. I've updated the file location. I think SVG will work as there are others in the supported_brands folder.

rohankapoorcom
rohankapoorcom previously approved these changes Jan 21, 2019
Copy link
Member

@rohankapoorcom rohankapoorcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@frenck frenck removed the to-do label Jan 21, 2019
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @oblogic7, I've left some comments, could you please take a look? 👍

source/_components/binary_sensor.owlet.markdown Outdated Show resolved Hide resolved
source/_components/binary_sensor.owlet.markdown Outdated Show resolved Hide resolved
source/_components/owlet.markdown Outdated Show resolved Hide resolved
source/_components/owlet.markdown Outdated Show resolved Hide resolved
source/_components/owlet.markdown Outdated Show resolved Hide resolved
source/_components/sensor.owlet.markdown Outdated Show resolved Hide resolved
source/_components/sensor.owlet.markdown Outdated Show resolved Hide resolved
@frenck frenck added in-progress This PR/Issue is currently being worked on and removed ready-for-review This PR needs to be reviewed labels Jan 21, 2019
Wording.  Remove ha_qa_scale.
@oblogic7
Copy link
Contributor Author

@frenck Requested changes are complete.

@frenck frenck self-assigned this Jan 22, 2019
@frenck frenck added ready-for-review This PR needs to be reviewed and removed in-progress This PR/Issue is currently being worked on labels Jan 22, 2019
frenck
frenck previously approved these changes Jan 22, 2019
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.
⚠️ The ha_release might need an update before merging this one in.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Jan 22, 2019
@frenck frenck removed the ready-for-review This PR needs to be reviewed label Jan 22, 2019
You must have the [Owlet component](/components/owlet/) configured to use this sensor.
</p>

## {% linkable_title Configuration %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this section. It's not correct. The platform is only loaded via discovery from the component.

featured: true
ha_release: "0.87"
ha_iot_class: "Cloud Polling"
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge this page with the component page as platforms don't require any configuration.

logo: owlet.svg
ha_category: Health
featured: true
ha_release: "0.87"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.89

footer: true
logo: owlet.svg
ha_category: Health
featured: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this.

featured: true
ha_release: "0.87"
ha_iot_class: "Cloud Polling"
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this page and merge content with component page.

@oblogic7 oblogic7 mentioned this pull request Feb 16, 2019
2 tasks
@oblogic7
Copy link
Contributor Author

@MartinHjelmare Something blew up this branch during rebase too. I'm thinking something is wonky with my PyCharm git integration. Created a new PR (#8608) from clean working branch.

@oblogic7 oblogic7 closed this Feb 16, 2019
@ghost ghost removed the awaits-parent Awaits the merge of an parent PR label Feb 16, 2019
@oblogic7 oblogic7 deleted the owlet branch February 16, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-parent This PR has a parent PR in a other repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants