New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Owlet Component Documentation #8217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logo is not working. See: https://deploy-preview-8217--home-assistant-docs.netlify.com/components/owlet/
I think you have to use a png, not an svg.
Looks like I didn't get the file into the supported_brands folder when I dropped it onto the project. I've updated the file location. I think SVG will work as there are others in the supported_brands folder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @oblogic7, I've left some comments, could you please take a look? 👍
Wording. Remove ha_qa_scale.
@frenck Requested changes are complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Approved. Can be merged as soon as the parent PR gets merged.
ha_release
might need an update before merging this one in.
Wording. Remove ha_qa_scale.
You must have the [Owlet component](/components/owlet/) configured to use this sensor. | ||
</p> | ||
|
||
## {% linkable_title Configuration %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this section. It's not correct. The platform is only loaded via discovery from the component.
featured: true | ||
ha_release: "0.87" | ||
ha_iot_class: "Cloud Polling" | ||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can merge this page with the component page as platforms don't require any configuration.
source/_components/owlet.markdown
Outdated
logo: owlet.svg | ||
ha_category: Health | ||
featured: true | ||
ha_release: "0.87" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.89
source/_components/owlet.markdown
Outdated
footer: true | ||
logo: owlet.svg | ||
ha_category: Health | ||
featured: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this.
featured: true | ||
ha_release: "0.87" | ||
ha_iot_class: "Cloud Polling" | ||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this page and merge content with component page.
…into owlet Conflicts: source/_components/owlet.markdown
@MartinHjelmare Something blew up this branch during rebase too. I'm thinking something is wonky with my PyCharm git integration. Created a new PR (#8608) from clean working branch. |
Description:
Add documentation for Owlet component
Pull request in home-assistant (if applicable): home-assistant/core#20258
Checklist:
next
is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent
.