Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yeelight flow action param support #8628

Merged
merged 1 commit into from Feb 19, 2019
Merged

Add yeelight flow action param support #8628

merged 1 commit into from Feb 19, 2019

Conversation

zewelor
Copy link
Contributor

@zewelor zewelor commented Feb 18, 2019

Description:
Add yeelight flow action param support

Pull request in home-assistant (if applicable): home-assistant/core#21195

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the [standards][standards].

@@ -196,11 +197,11 @@ light:

### {% linkable_title Custom effects %}

This example shows how you can add your custom effects in your configuration.
This example shows how you can add your custom effects in your configuration. To turn on you can use [light.turn_on](/components/light/#service-lightturn_on) service.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To turn on the light .. ? The sentence sounds a bit off.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@rytilahti rytilahti merged commit 7abcaad into home-assistant:next Feb 19, 2019
@ghost ghost removed the to-do label Feb 19, 2019
@frenck frenck added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch has-parent This PR has a parent PR in a other repo labels Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-parent This PR has a parent PR in a other repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants