Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dyson new fans #8755

Merged
merged 3 commits into from Apr 9, 2019
Merged

Conversation

etheralm
Copy link
Contributor

@etheralm etheralm commented Feb 26, 2019

Description: Add information about the 2018 Dyson Purecool air purifiers.

Pull request in home-assistant (if applicable): home-assistant/core#22215

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@klaasnicolaas klaasnicolaas added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration ready-for-review This PR needs to be reviewed next This PR goes into the next branch has-parent This PR has a parent PR in a other repo and removed to-do labels Feb 26, 2019
@frenck frenck added the parent-merged The parent PR has been merged already label Apr 2, 2019
@frenck frenck self-assigned this Apr 2, 2019
@frenck
Copy link
Member

frenck commented Apr 8, 2019

@etheralm I'm confused about this PR. Could you enlighten me about the status?
Seems like this PR depends on 2 parents? One is merged, the other is open....

Is this now ready to merge or not?!

@etheralm
Copy link
Contributor Author

etheralm commented Apr 8, 2019

@frenck the parent for this one is 22215 and it is already merged, this one should be ready to merge. I've split the documentation changes for the other pr that is still not ready in a separate pr.

@klaasnicolaas klaasnicolaas removed the ready-for-review This PR needs to be reviewed label Apr 8, 2019
@klaasnicolaas klaasnicolaas merged commit 9e62468 into home-assistant:next Apr 9, 2019
@klaasnicolaas
Copy link
Member

I will merge this and continue your work with PR #9103 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-parent This PR has a parent PR in a other repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch parent-merged The parent PR has been merged already
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants