New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update automation.markdown #8778
Conversation
Clarification of initial_state behaviour
source/_docs/automation.markdown
Outdated
@@ -52,6 +52,7 @@ Actions are all about calling services. To explore the available services open t | |||
If you always want your automations to be enabled or disabled upon Home Assistant restart, then you have to set an initial state in your automations. Otherwise the previous state will be restored. | |||
|
|||
If an automation is disabled (turned off) then it will never trigger. Only automations that are enabled (turned on) will trigger. | |||
To have your automation enabled you should either add `initial_state: true` to your automation description (it will always make it enabled on Home Assistant startup) or turn it on manually via UI/another automation/developer tools (that way the last stored state of the automation will be restored on the next Home Assistant startup). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this covered already above (line 52)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @rohankapoorcom on this @akasma74, it is already stated at line 52.
It would make more sense to extend the description of line 52 instead of adding it at this place (and kinda repeating things).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have a look at the amended version.
The main reason of this PR is that the current text covers state's restoration , but says nothing about initial state of newly created automation without initial_state
(that behaviour has changed recently to opposite), these 2 things are completely separate and should not be mixed up/omitted.
It also says nothing about HA startup failure.
Hope that makes more sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some clarification about restoring state and HA startup failure
come more adjustments and clarification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more clarification and adjustment
Thanks, @akasma74! |
This PR should have never been merged because it added false statements to the documentation. It states this:
That is completely false. How did such an utterly invalid statement every pass the vetting process? I've created dozens of automations (from version 0.84 when the restore feature changed to use a JSON store up to version 0.91) and they are all enabled by default. None of my automations employ This PR should be reversed. The revised documentation it introduced is false and misleads users to believe The previous documentation was correct:
NOTE |
@tdejneka Have you read my comments to this PR and the supporting discussions? You are referring to your personal experience. That's great, but not enough to prove the fact I'm afraid. And after all, HA is evolving and if now it's different - feel free to make your own PR. |
In the evidence you've provided (the linked community discussion) I was an active participant. The issue of The discussion thread was created shortly after version 0.85 was released. Many users were jumping from pre-version 0.84 and first encountering the newly revised restore feature which, as mentioned, defaulted to setting all automations to The fix was to simply turn them back on (using the Services page) and then the restore feature would take care of future restarts. However, the updated restore feature became conflated with the This spectacularly bad advice omitted to mention that it overrides the functionality of the restore feature and causes the affected automations to have their This PR only served to make a bad situation worse by stating all new automations are turned off by default (they are not) and that the corrective action is the obligatory inclusion of You've chosen to focus on 'feelings' as opposed to the core issue that numerous users have been led astray by misinformation. I interpret your response as misdirection and a reluctance to correct the mistake. I'll take the initiative to do it myself. |
As far as I remember, this PR served 2 purposes, one of them - to clarify what happens when the restore feature fails. There was nothing about that in docs before this PR as the feature was rather new and added (apparently) without reflecting any details in docs.
there is nothing bad in having some automations always enabled, especially those responsible for critical tasks. speaking about users who mindlessly copy stuff - well, every feature might be dangerous is used by not very competent person.
perhaps because there was (and still is) no such information anywhere in the docs.
Possibly. Sorry, I haven't got time to investigate it properly at the moment.
You mean my previous response was all about feelings and nothing else? Oh dear.. I'd love to see your/anyone else's PR that fixes this matter because all I want to achieve is better documentation as I deeply understand how annoying can it be to use incomplete/outdated/wrong information. I'm not looking for fame or any special status here ;) |
You wrote more about "offense" and "politeness" than addressing the false statements you introduced into the documentation. New automations are not In fact, your only response to those erroneous statements has been:
It takes less than minute to prove the documentation is wrong. The simple answer would've been to acknowledge it was a mistake and that it would be corrected ASAP. FWIW, I've posted a draft version of the new documentation here for public commentary. |
I'm going to lock this conversation for two reasons.
Above documentation is indeed incorrect and should not have been merged (my bad). |
Clarification of initial_state behaviour
Description:
It it now unclear that automation is disabled by default and one need to enable each and every one the one way or another, which creates a lot of discussions like that
Pull request in home-assistant (if applicable): home-assistant/home-assistant#
Checklist:
next
is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent
.