Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Cloud Platform Documentation #9367

Merged
merged 10 commits into from Jun 18, 2019
Merged

Conversation

lufton
Copy link
Contributor

@lufton lufton commented May 2, 2019

Description:
Google Cloud component documentation

Pull request in home-assistant: home-assistant/core#23629

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@lufton lufton marked this pull request as ready for review May 2, 2019 11:19
source/_components/google_cloud_tts.markdown Outdated Show resolved Hide resolved
source/_components/google_cloud_tts.markdown Outdated Show resolved Hide resolved
source/_components/google_cloud_tts.markdown Outdated Show resolved Hide resolved
source/_components/google_cloud_tts.markdown Outdated Show resolved Hide resolved
@awarecan
Copy link
Contributor

awarecan commented May 3, 2019

Please add a paragraph to discuss the price Google Cloud TTS may cost.

@klaasnicolaas klaasnicolaas added has-parent This PR has a parent PR in a other repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch ready-for-review This PR needs to be reviewed and removed to-do labels May 3, 2019
* Structurized
* Changed icon
@lufton lufton changed the title Google Cloud TTS service component manual Google Cloud component manual May 3, 2019
source/_components/google_cloud.markdown Outdated Show resolved Hide resolved
@lufton lufton changed the title Google Cloud component manual Google Cloud Platform Documentation May 5, 2019
@frenck frenck added the parent-merged The parent PR has been merged already label Jun 7, 2019
Copy link
Contributor Author

@lufton lufton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@klaasnicolaas @awarecan can somebody explain why it says:

1 review requesting changes by reviewers with write access.

And wouldn't let PR to merge? I don't see any change request that is actual.

@frenck frenck self-assigned this Jun 18, 2019
@frenck frenck removed the ready-for-review This PR needs to be reviewed label Jun 18, 2019
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @lufton! 👍

@frenck frenck dismissed klaasnicolaas’s stale review June 18, 2019 10:39

Comments Addressed

@frenck frenck merged commit 84de78d into home-assistant:next Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-parent This PR has a parent PR in a other repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch parent-merged The parent PR has been merged already
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants