Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃敟Removes linkable_title everywhere #9772

Merged
merged 5 commits into from Jul 4, 2019
Merged

馃敟Removes linkable_title everywhere #9772

merged 5 commits into from Jul 4, 2019

Conversation

frenck
Copy link
Member

@frenck frenck commented Jul 4, 2019

Description:

This removes the # {% linkable_title Header title %} from our website, restoring Markdown as it should be.

The PR has multiple commits, one commits removes all the linkable_title's from the website, the others contain the technical changes. Since this PR is darn large, it probably helps to check the preview and the tech commits PR's separately.

Pull request in home-assistant (if applicable): home-assistant/home-assistant#

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@frenck frenck changed the title Frenck 2019 0090 馃敟Removes linkable_title everywhere Jul 4, 2019
@frenck frenck added current This PR goes into the current branch enhancement ready-for-review This PR needs to be reviewed labels Jul 4, 2019
@frenck frenck added this to In progress in Website development via automation Jul 4, 2019
@klaasnicolaas
Copy link
Member

No no no, this PR is wayyyy to big 馃憖

pvizeli
pvizeli previously approved these changes Jul 4, 2019
klaasnicolaas
klaasnicolaas previously approved these changes Jul 4, 2019
@frenck frenck changed the title 馃敟Removes linkable_title everywhere WIP: 馃敟Removes linkable_title everywhere Jul 4, 2019
@frenck
Copy link
Member Author

frenck commented Jul 4, 2019

鈿狅笍 Please do not merge. I want to do some extensive checking in the build output

@frenck frenck dismissed stale reviews from klaasnicolaas and pvizeli via 17a2a9a July 4, 2019 16:56
@frenck frenck changed the title WIP: 馃敟Removes linkable_title everywhere 馃敟Removes linkable_title everywhere Jul 4, 2019
@frenck
Copy link
Member Author

frenck commented Jul 4, 2019

Re-instated the linkable_title plugin, but now acts as a NOOP.
This prevents issues when we merge with other branches (e.g., PR's that haven't updated).

This NOOP plugin can be removed over time.

@frenck frenck merged commit ebca321 into current Jul 4, 2019
Website development automation moved this from In progress to Done Jul 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the frenck-2019-0090 branch July 4, 2019 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current This PR goes into the current branch ready-for-review This PR needs to be reviewed
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants