Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_group attribute to light groups #14081

Closed
krissen opened this issue Apr 25, 2018 · 5 comments
Closed

Add is_group attribute to light groups #14081

krissen opened this issue Apr 25, 2018 · 5 comments

Comments

@krissen
Copy link

krissen commented Apr 25, 2018

Home Assistant release with the issue: 0.67.1

Component/platform: light groups doc

Description of problem: impossible to differentiate between actual lights, and light groups.

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

- platform: group
  name: rooma
  entities:
    - light.bulb1
    - light.bulb2

Additional information: There are scenarios (like this) where it would be helpful to be able to differentiate between actual lights (light.bulb1 and light.bulb2 in the configuration above) and a light group (eg. light.rooma). This could be done by automatically adding an attribute to light groups; for instance is_group = true, similar to the attribute is_hue_group: true which is set for light groups imported through hue.

@krissen
Copy link
Author

krissen commented Apr 25, 2018

Hmm. Not sure if you consider this a bug or a feature request. x-D Posted one there too.

@OttoWinter
Copy link
Member

All attributes are stored in each state object and therefore land in the database with every single state change. The project tries to minimize the amount of static attributes to optimize states and not open a can of worms (there would be tons of feature requests with a certain attribute that should be added and would ultimately clutter the database).

Admittedly, there are quite a few components that use static attributes right now, but that doesn't mean we should repeat past mistakes.

Also, the light group platform should behave like & and have the attributes as any other light by design. They should essentially be indistinguishable from single lights in the frontend.

In the use-case you linked to: why not just create a custom blacklist? I mean you have to create separate configuration sections for each light group anyway, so I honestly don't see the reason why a whole new attribute should be added when a simple little blacklist would probably work just fine.

@fanaticDavid
Copy link
Contributor

You could also consider just adding the keyword group to the name, which you're defining in the configuration anyway.

@balloobbot
Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍

@balloobbot
Copy link

This issue will be auto-closed because there hasn't been any activity for a few months. Feel free to open a new one if you still experience this problem 👍

@home-assistant home-assistant locked and limited conversation to collaborators Dec 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants