Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media Player volume up/down requires SUPPORT_VOLUME_SET but not SUPPORT_VOLUME_STEP #23418

Closed
andrewsayre opened this issue Apr 26, 2019 · 1 comment · Fixed by #23419
Closed
Assignees

Comments

@andrewsayre
Copy link
Member

Home Assistant release with the issue: 0.92.0

Last working Home Assistant release (if known): < 0.92.0

Operating environment (Hass.io/Docker/Windows/etc.): All

Component/platform: media_player

Description of problem:
#22878 introduced a gate that checks a media player platform reports a support feature flag corresponding to a service call before invoking the service. volume_down and volume_up were mapped to SUPPORT_VOLUME_SET but should allow SUPPORT_VOLUME_STEP. This affects platforms that only support stepping the volume up/down and not setting it to an explicit value.

Additional notes:*
The gate should check for either SUPPORT_VOLUME_SET or SUPPORT_VOLUME_STEP in required features.

@andrewsayre andrewsayre changed the title Media player volume up/down requires volume set Media player volume up/down requires SUPPORT_VOLUME_SET but not SUPPORT_VOLUME_STEP Apr 26, 2019
@andrewsayre andrewsayre changed the title Media player volume up/down requires SUPPORT_VOLUME_SET but not SUPPORT_VOLUME_STEP Media Player volume up/down requires SUPPORT_VOLUME_SET but not SUPPORT_VOLUME_STEP Apr 26, 2019
@andrewsayre
Copy link
Member Author

andrewsayre commented Apr 26, 2019

Reported by user qq discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant