Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zestimate: component should set sensor names to address #23757

Closed
dreed47 opened this issue May 8, 2019 · 0 comments · Fixed by #23770
Closed

Zestimate: component should set sensor names to address #23757

dreed47 opened this issue May 8, 2019 · 0 comments · Fixed by #23770
Labels
integration: zestimate

Comments

@dreed47
Copy link
Contributor

dreed47 commented May 8, 2019

Home Assistant release with the issue: 0.92.2

Last working Home Assistant release (if known): unknown

Operating environment (Hass.io/Docker/Windows/etc.): all

Component/platform: https://www.home-assistant.io/components/zestimate/

Description of problem:
Zestimate component sets sensor names to "Zestimate". So if you specify multiple properties (ZPID) then you end up with multiple sensors all with the same "Zestimate" name. It would be more useful if the component set the name to the address of the property for which you're getting the estimate. Or possibly a combination such as...

Zestimate 123 East Main Street

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

sensor:
  - platform: zestimate
    api_key: YOUR_API_KEY
    zpid:
      - YOUR_ZPID_1
      - YOUR_ZPID_2

Traceback (if applicable): N/A

Additional information:
@dreed47 dreed47 mentioned this issue May 9, 2019
Merged
9 tasks
fabaff pushed a commit that referenced this issue May 24, 2019
@dreed47 @fabaff
Update the name of Zestimate sensors (#23770)
0a9a8ec 
* Zestimate: fix for issue #23757
Changed name property to return Zestimate
and the property address.  This will make it easier
distinguish multiple Zestimate sensor entities
in the UI.

Also removed MIN_TIME_BETWEEN_UPDATES in
favor of SCAN_INTERVAL per suggestion from
amelchio#9580 on Discord

* Zestimate fix for issue #23757

Changed name property to return Zestimate
and the property address.  This will make it easier
distinguish multiple Zestimate sensor entities
in the UI.

* Changed name property to return Zestimate
and the property address.  This will make it easier
distinguish multiple Zestimate sensor entities
in the UI.

* moved code fix to the correct function

* removed code change from unique_id function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
integration: zestimate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update the name of Zestimate sensors
2 participants
@dreed47 @rytilahti