Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geniushub integration issue #24530

Closed
persil1971 opened this issue Jun 14, 2019 · 6 comments · Fixed by #24546
Closed

Geniushub integration issue #24530

persil1971 opened this issue Jun 14, 2019 · 6 comments · Fixed by #24546

Comments

@persil1971
Copy link

Home Assistant release with the issue:

0.94.3

Last working Home Assistant release (if known):
N/A

Operating environment (Hass.io/Docker/Windows/etc.):

Component/platform:

/components/geniushub

Description of problem:
Error in log at startup

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

Traceback (if applicable):

Fri Jun 14 2019 10:31:19 GMT+0100 (British Summer Time)
_convert_zone(): Failed to convert Timer schedule for Zone 12
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/geniushubclient/__init__.py", line 259, in _convert_zone
    elif setpoint_temp != default_temp:                          # noqa: disable=F821; pylint: disable=used-before-assignment
UnboundLocalError: local variable 'setpoint_temp' referenced before assignment

Additional information:

@ghost
Copy link

ghost commented Jun 14, 2019

Hey there @zxdavb, mind taking a look at this issue as its been labeled with a integration (geniushub) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@zxdavb
Copy link
Contributor

zxdavb commented Jun 14, 2019

@persil1971 This is potentially the most embarrassing piece of code I've ever written.

The good new is that I know exactly what is going on, and that there is a fix, which will be made available in the next few days, after some more testing.

@persil1971
Copy link
Author

persil1971 commented Jun 17, 2019 via email

balloob pushed a commit that referenced this issue Jun 17, 2019
…24546)

* bump client library to workaround #24530

* bump client library to workaround #24530 2/2

* bump client library to workaround #24530

* bump client library to workaround #24530 2/2

* bugfix: ghost devices cause TypeError: 'NoneType' object is not subscriptable

* bugfix: broken HW zones cause AttributeError: 'GeniusZone' object has no attribute 'temperature'

* delint
@zxdavb
Copy link
Contributor

zxdavb commented Jun 17, 2019

Many thanks for looking into this for me - it's much appreciated. Would you also be able to look at this or should I open a separate issue? Log Details
(ERROR) Mon Jun 17 2019 10:10:21 GMT+0100 (British Summer Time) Device 3: Type 'Single Channel Receiver', doesn't match Fingerprint 'Dual Channel Receiver'

OK, the issue is that I never had a SCR to test against. I will need a copy of your JSON, see:
https://github.com/zxdavb/geniushub-client

... and execute the following:

python ghclient.py ${HUB_ADDRESS} -u ${USERNAME} -p ${PASSWORD} devices -vvv

...and PM me the results at:
https://forum.geniushub.co.uk/t/home-automation-python-cli-client-library-now-available/292/18

@zxdavb
Copy link
Contributor

zxdavb commented Jun 18, 2019

@persil1971 Could you do the above and, yes, please also open an issue in HA.

@persil1971
Copy link
Author

persil1971 commented Jun 18, 2019 via email

@balloob balloob mentioned this issue Jun 26, 2019
alandtse pushed a commit to alandtse/home-assistant that referenced this issue Oct 12, 2019
… edge cases (home-assistant#24546)

* bump client library to workaround home-assistant#24530

* bump client library to workaround home-assistant#24530 2/2

* bump client library to workaround home-assistant#24530

* bump client library to workaround home-assistant#24530 2/2

* bugfix: ghost devices cause TypeError: 'NoneType' object is not subscriptable

* bugfix: broken HW zones cause AttributeError: 'GeniusZone' object has no attribute 'temperature'

* delint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants