Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] New Device Tracker Plaform : Freebox #10702

Closed
wants to merge 17 commits into from
Closed

Conversation

2t0m
Copy link

@2t0m 2t0m commented Nov 20, 2017

Description:

I have been testing this new device tracker platform for a month.

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#4024

Example entry for configuration.yaml (if applicable):

device_tracker:
  - platform: freebox
    host: https://something.freeboxos.fr
    username: fr.freebox.testapp
    password: bi9dpCD4v75mtX7HTGFxPeATc0kYWe0+aHfdBDx3wiEYEtULZ3kRKwdjvJHYDFGAT

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

device['l3connectivities'][0]['addr'],
now))
_LOGGER.debug("Freebox - Device at Home : " +
device['names'][0]['name'])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continuation line under-indented for visual indent

import logging
import urllib.parse
import urllib.request
import ssl

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'ssl' imported but unused

@tinloaf
Copy link
Contributor

tinloaf commented Nov 20, 2017

Hi! Thanks for this PR. Have you thought about factoring out the device specific API into a small python package, putting it on pypi and then using it in this PR? That way, others can also benefit from your work. Also, we try to minimize the amount of device-API specific code in home assistant.

@2t0m
Copy link
Author

2t0m commented Nov 20, 2017

Hi! Thanks for your answer and advice. I will think about a pypi package as soon as I get time. I promise.

@tinloaf
Copy link
Contributor

tinloaf commented Nov 20, 2017

I'm taking the liberty to add a "[WIP]" to the title. This will indicate to the maintainers that this is not ready for merging yet. Just remove the "[WIP]" whenever you think this is ready for reviews / merging. Currently I think most reviews would just say "please factor out the device-specific code".

@tinloaf tinloaf changed the title New Device Tracker Plaform : Freebox [WIP] New Device Tracker Plaform : Freebox Nov 20, 2017
@fabaff
Copy link
Member

fabaff commented Jan 25, 2018

This PR is gone stale. Please re-open it if you plan to continue.

@fabaff fabaff closed this Jan 25, 2018
@stilllman stilllman mentioned this pull request Feb 26, 2018
9 tasks
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants