-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] New Device Tracker Plaform : Freebox #10702
Conversation
device['l3connectivities'][0]['addr'], | ||
now)) | ||
_LOGGER.debug("Freebox - Device at Home : " + | ||
device['names'][0]['name']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
continuation line under-indented for visual indent
import logging | ||
import urllib.parse | ||
import urllib.request | ||
import ssl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'ssl' imported but unused
Hi! Thanks for this PR. Have you thought about factoring out the device specific API into a small python package, putting it on pypi and then using it in this PR? That way, others can also benefit from your work. Also, we try to minimize the amount of device-API specific code in home assistant. |
Hi! Thanks for your answer and advice. I will think about a pypi package as soon as I get time. I promise. |
I'm taking the liberty to add a "[WIP]" to the title. This will indicate to the maintainers that this is not ready for merging yet. Just remove the "[WIP]" whenever you think this is ready for reviews / merging. Currently I think most reviews would just say "please factor out the device-specific code". |
This PR is gone stale. Please re-open it if you plan to continue. |
Description:
I have been testing this new device tracker platform for a month.
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#4024
Example entry for
configuration.yaml
(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
tox
run successfully. Your PR cannot be merged unless tests passREQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices:
tox
run successfully. Your PR cannot be merged unless tests pass