Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add away mode support for generic thermostat #11081

Closed
wants to merge 1 commit into from

Conversation

fanthos
Copy link
Contributor

@fanthos fanthos commented Dec 11, 2017

Description:

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#4202

Example entry for configuration.yaml (if applicable):

climate:
  - platform: generic_thermostat
    name: Study
    heater: switch.study_heater
    target_sensor: sensor.study_temperature
    away_temp_cool: 14
    away_temp_heat: 34

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass

@fanthos fanthos changed the title Add away mode support for generic thermostat [Need more work]Add away mode support for generic thermostat Dec 11, 2017
@fanthos
Copy link
Contributor Author

fanthos commented Dec 11, 2017

Not sure if I need to call the function in turn_away_mode_on and turn_away_mode_on or not.
self.schedule_update_ha_state()

I am confused about difference between
schedule_update_ha_state()
async_schedule_update_ha_state()
yield from self.async_update_ha_state()

Another problem, away mode does not restore after server restart.

@fanthos fanthos changed the title [Need more work]Add away mode support for generic thermostat Add away mode support for generic thermostat Dec 12, 2017
fanthos added a commit to fanthos/home-assistant.github.io that referenced this pull request Dec 12, 2017
fanthos added a commit to fanthos/home-assistant.github.io that referenced this pull request Dec 12, 2017
@pvizeli pvizeli changed the title Add away mode support for generic thermostat [WIP] Add away mode support for generic thermostat Dec 13, 2017
@ciotlosm
Copy link
Contributor

Would be nice if you could also allow an option to link this directly to an entity providing home / away status. Most people group all device trackers under a "Presence" or "Family", so that could be used as trigger automatically without extra automation.

Unsure if it's realistic, but would make the component even more useful with default config only.

@ciotlosm
Copy link
Contributor

I've done a few more fixes and integrated part of your changes in this PR #11325
I will update documentation once people decide the pull request is ok considering I have some breaking changes to functionality on the way states are represented and one startup setting.

@Danielhiversen
Copy link
Member

@fanthos @ciotlosm :
Is this pr still relevant? Or should we close it?

@fanthos
Copy link
Contributor Author

fanthos commented Jan 23, 2018

I think this feature already included in #11445 .

@fanthos fanthos closed this Jan 23, 2018
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants