Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.63.2 #12402

Merged
merged 6 commits into from
Feb 14, 2018
Merged

0.63.2 #12402

merged 6 commits into from
Feb 14, 2018

Conversation

balloob
Copy link
Member

@balloob balloob commented Feb 14, 2018

balloob and others added 5 commits February 13, 2018 22:03
* Add check for unsupported features

* Lint fix

* change to guard clause
* 📝 Fix WUnderground names

* 👻 Fix using event loop callback
The yamaha component previously used a property named unique_id to
ensure that exactly 1 media_player was discovered per zone per
control_url. This was introduced so that hard coded devices wouldn't
be duplicated by automatically discovered devices.

In HA 0.63 unique_id became a reserved concept as part of the new
device registry, and the property was removed from the component. But
the default returns None, which had the side effect of only ever
registering a single unit + zone, the first one discovered. This was
typically the Main_Zone of the unit, but there is actually no
guaruntee of that.

This fix brings back the logic under a different property called
zone_id. This is not guarunteed to be globally stable like unique_id
is supposed to be, but it is suitable for the deduplication for yamaha
media players.
@balloob balloob requested review from andrey-git and a team as code owners February 14, 2018 06:12
@homeassistant homeassistant added cla-signed integration: mercedesme core merging-to-master This PR is merging into the RC branch and should probably change the branch to `dev`. platform: binary_sensor.mercedesme labels Feb 14, 2018
@balloob balloob merged commit d85ed8d into master Feb 14, 2018
@syssi
Copy link
Member

syssi commented Feb 14, 2018

Please merge #12392, too. It's somehow part of #12368

@balloob balloob deleted the release-0-63-2 branch February 15, 2018 07:35
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants