Cleanup http #12424
Merged
Cleanup http #12424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 15, 2018
tests/components/http/test_auth.py
Outdated
| KEY_TRUSTED_NETWORKS, KEY_USE_X_FORWARDED_FOR, HTTP_HEADER_X_FORWARDED_FOR) | ||
| from homeassistant.components.http.auth import setup_auth | ||
| from homeassistant.components.http.real_ip import setup_real_ip | ||
| from homeassistant.components.http.const import KEY_AUTHENTICATED, KEY_REAL_IP |
There was a problem hiding this comment.
'homeassistant.components.http.const.KEY_REAL_IP' imported but unused
pvizeli
approved these changes
Feb 15, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
With aiohttp 3 around the corner, it was time to clean up our HTTP component. Splits out a bunch of stuff into middlewares and also makes sure that the auth middleware can no longer be changed on the fly. It will always use the initial used values.
Also cleaned up the tests related to HTTP.
Related issue (if applicable): solves some deprecation warnings for #12358
Example entry for
configuration.yaml(if applicable):http:Checklist:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass