Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Sphinx to 1.7.1 #13127

Merged
merged 1 commit into from
Mar 13, 2018
Merged

Upgrade Sphinx to 1.7.1 #13127

merged 1 commit into from
Mar 13, 2018

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Mar 12, 2018

Description

Changelog: http://www.sphinx-doc.org/en/stable/changes.html

Checklist:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@homeassistant homeassistant added small-pr PRs with less than 30 lines. cla-signed labels Mar 12, 2018
@balloob
Copy link
Member

balloob commented Mar 12, 2018

Last time the sphinx build was broken for months. Did you build a local sphinx build ?

@fabaff
Copy link
Member Author

fabaff commented Mar 12, 2018

Did you build a local sphinx build ?

Of course. There are usually a couple of warning but nothing fatal. Not sure why the move of the constants in the last November that caused the build issue wasn't detected earlier. I suspect that I didn't clean the output directory on a regular base.

@balloob balloob merged commit 989638b into dev Mar 13, 2018
@balloob balloob deleted the upgrade-Sphinx branch March 13, 2018 01:22
@balloob balloob mentioned this pull request Mar 30, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants