Log invalid templates in script delays #13423
Merged
+36
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
reviewed
Mar 24, 2018
homeassistant/helpers/script.py
Outdated
| except (TemplateError, vol.Invalid) as ex: | ||
| _LOGGER.error("Error rendering '%s' delay template: %s", | ||
| self.name, ex) | ||
| delay = timedelta(seconds=1) |
There was a problem hiding this comment.
I don't think that we should continue. We should abort instead
houndci-bot
reviewed
Mar 24, 2018
homeassistant/helpers/script.py
Outdated
| @@ -3,6 +3,7 @@ | |||
| import logging | |||
| from itertools import islice | |||
| from typing import Optional, Sequence | |||
| from datetime import timedelta | |||
There was a problem hiding this comment.
'datetime.timedelta' imported but unused
pvizeli
approved these changes
Mar 25, 2018
balloob
pushed a commit
that referenced
this pull request
Mar 26, 2018
* Log invalid templates in script delays * Abort on error * Remove unused import
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR makes the script
delay:survive invalid templates. We used to log two tracebacks and break the script so it never completed.Example entry for
configuration.yaml(if applicable):Checklist:
tox.If the code does not interact with devices: