New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel up and down for webostv #13624

Merged
merged 1 commit into from Apr 4, 2018

Conversation

Projects
None yet
6 participants
@stephanerosi
Contributor

stephanerosi commented Apr 1, 2018

This enable using the next and previous buttons on the media player interface to switch channels up and down, which is the desired default behaviour for a television.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [] New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • [] New dependencies are only imported inside functions that use them ([example][ex-import]).
  • [] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • [] New files were added to .coveragerc.

If the code does not interact with devices:

  • [] Tests have been added to verify that the new code works.
@homeassistant

This comment has been minimized.

homeassistant commented Apr 1, 2018

Hi @stephanerosi,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@stephanerosi stephanerosi deleted the stephanerosi:webostv-channel-up-down branch Apr 2, 2018

@stephanerosi stephanerosi restored the stephanerosi:webostv-channel-up-down branch Apr 2, 2018

@stephanerosi stephanerosi reopened this Apr 2, 2018

@syssi

syssi approved these changes Apr 4, 2018

It's a breaking change somehow but I support the suggestion!

@pepeEL

This comment has been minimized.

Contributor

pepeEL commented Apr 4, 2018

When this PR will be implement to master Home Assistant ?

@pvizeli pvizeli merged commit 4b2fdd2 into home-assistant:dev Apr 4, 2018

5 checks passed

WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.77%
Details
hound No violations found. Woof!
@ferdydek

This comment has been minimized.

ferdydek commented Apr 9, 2018

Could you please make sure this works only when "Live TV" is the active source.

Mostly these buttons are for next/previous track/menu, and since most people use services like plex netflix youtube etc rather than live tv, the intuitive default behavior would rather be previous and next (episode, video on playlist, etc) and not tv channel manipulation.

@stephanerosi

This comment has been minimized.

Contributor

stephanerosi commented Apr 9, 2018

@ferdydek
You're right, I'll update the pull request

@stephanerosi

This comment has been minimized.

Contributor

stephanerosi commented Apr 11, 2018

@pvizeli
I updated my branch. How do I update my pull request? Should I create a new pull request?
Thanks

@stephanerosi stephanerosi referenced this pull request Apr 11, 2018

Merged

Webostv channel up down only on LiveTV #13829

1 of 8 tasks complete

@balloob balloob referenced this pull request Apr 13, 2018

Merged

0.67.0 #13856

@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.