Improving icloud device tracker #14078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
2 tasks
|
Anyone could take a look? |
fabaff
reviewed
Apr 28, 2018
| @@ -79,8 +80,11 @@ def setup_scanner(hass, config: dict, see, discovery_info=None): | |||
| username = config.get(CONF_USERNAME) | |||
| password = config.get(CONF_PASSWORD) | |||
| account = config.get(CONF_ACCOUNTNAME, slugify(username.partition('@')[0])) | |||
| max_interval = config.get(CONF_MAX_INTERVAL, 30) | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Default should be set in the PLATFORM_SCHEMA.
There was a problem hiding this comment.
Agree, fixed that. Re-ran all tests and checks. Tested manually that defaults values do take effect.
fabaff
reviewed
Apr 28, 2018
| @@ -79,8 +80,11 @@ def setup_scanner(hass, config: dict, see, discovery_info=None): | |||
| username = config.get(CONF_USERNAME) | |||
| password = config.get(CONF_PASSWORD) | |||
| account = config.get(CONF_ACCOUNTNAME, slugify(username.partition('@')[0])) | |||
| max_interval = config.get(CONF_MAX_INTERVAL, 30) | |||
| gps_accuracy_threshold = config.get(CONF_GPS_ACCURACY_THRESHOLD, 1000) | |||
There was a problem hiding this comment.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Any updates? |
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
* Improving icloud device tracker * Adding config validations for new values * Adding config validations for new values * Moving icloud specific setup to platform schema. Setting default in platform schema.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5240
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passBefore commit
After commit
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
Component does not have tests yet. Might be a matter for next commit.