-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving icloud device tracker #14078
Conversation
This comment has been minimized.
This comment has been minimized.
Anyone could take a look? |
@@ -79,8 +80,11 @@ def setup_scanner(hass, config: dict, see, discovery_info=None): | |||
username = config.get(CONF_USERNAME) | |||
password = config.get(CONF_PASSWORD) | |||
account = config.get(CONF_ACCOUNTNAME, slugify(username.partition('@')[0])) | |||
max_interval = config.get(CONF_MAX_INTERVAL, 30) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default should be set in the PLATFORM_SCHEMA
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, fixed that. Re-ran all tests and checks. Tested manually that defaults values do take effect.
@@ -79,8 +80,11 @@ def setup_scanner(hass, config: dict, see, discovery_info=None): | |||
username = config.get(CONF_USERNAME) | |||
password = config.get(CONF_PASSWORD) | |||
account = config.get(CONF_ACCOUNTNAME, slugify(username.partition('@')[0])) | |||
max_interval = config.get(CONF_MAX_INTERVAL, 30) | |||
gps_accuracy_threshold = config.get(CONF_GPS_ACCURACY_THRESHOLD, 1000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dito
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Any updates? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🐦
* Improving icloud device tracker * Adding config validations for new values * Adding config validations for new values * Moving icloud specific setup to platform schema. Setting default in platform schema.
Description:
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5240
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passBefore commit
After commit
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices:
Component does not have tests yet. Might be a matter for next commit.