Add battery attribute to Sensibo #14735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
platform: climate.sensibo
small-pr
fabaff
reviewed
Jun 1, 2018
| if 'batteryVoltage' in self._measurements: | ||
| return self._measurements['batteryVoltage'] | ||
| else: | ||
| return None |
There was a problem hiding this comment.
Using return self._measurements.get('batteryVoltage') is enough.
There was a problem hiding this comment.
Seen. Thanks!
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
* Added battery attribute * Simplify current_battery
ghost
added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added battery voltage attribute, which is reported by v1 pods.
Checklist:
tox. Your PR cannot be merged unless tests pass