Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch the ValueError if the bulb was in the wrong mode #15434

Merged
merged 1 commit into from
Jul 13, 2018
Merged

Catch the ValueError if the bulb was in the wrong mode #15434

merged 1 commit into from
Jul 13, 2018

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jul 12, 2018

Description:

If the bulb is set to mono with the App then it appear as not available in Home Assistant. Currently there is no conversion from mono to hsv but I will try to get the HSV values for the mono mode from the vendor.

Example entry for configuration.yaml (if applicable):

light:
  - platform: mystrom
    name: Office
    host: 192.168.0.51
    mac: 5CA37GA0GF40

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@ghost ghost assigned fabaff Jul 12, 2018
@ghost ghost added the in progress label Jul 12, 2018
@fabaff fabaff merged commit 79955a5 into dev Jul 13, 2018
@ghost ghost removed the in progress label Jul 13, 2018
@fabaff fabaff deleted the mystrom-mono branch July 13, 2018 18:02
@balloob balloob mentioned this pull request Jul 20, 2018
Merged
michaeldavie pushed a commit to michaeldavie/home-assistant that referenced this pull request Jul 31, 2018
@fabaff @michaeldavie
Catch the ValueError if the bulb was in the wrong mode (home-assistan…
4bfbbe0 
…t#15434)
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
@fabaff
Catch the ValueError if the bulb was in the wrong mode (home-assistan…
693c17e 
…t#15434)
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@fabaff fabaff

Labels
cla-signed integration: mystrom small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabaff @homeassistant