Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract SSL context creation to helper #15483

Merged
merged 2 commits into from
Jul 16, 2018
Merged

Extract SSL context creation to helper #15483

merged 2 commits into from
Jul 16, 2018

Conversation

balloob
Copy link
Member

@balloob balloob commented Jul 16, 2018

Description:

Simplify connector creation for the aiohttp client helper. Makes sure we use Mozilla suggestions everywhere.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.74 milestone Jul 16, 2018
@balloob balloob requested a review from a team as a code owner July 16, 2018 07:39
@homeassistant homeassistant added core small-pr PRs with less than 30 lines. cla-signed labels Jul 16, 2018
@ghost ghost assigned balloob Jul 16, 2018
@ghost ghost added the in progress label Jul 16, 2018
@balloob balloob changed the title Simplify connector creation Extract SSL context creation to helper Jul 16, 2018
@balloob balloob merged commit ad4cba7 into dev Jul 16, 2018
@ghost ghost removed the in progress label Jul 16, 2018
@balloob balloob deleted the aiohttp-verify branch July 16, 2018 08:43
balloob added a commit that referenced this pull request Jul 16, 2018
* Extract SSL context creation to helper

* Lint
balloob added a commit that referenced this pull request Jul 16, 2018
* Extract SSL context creation to helper (#15483)

* Extract SSL context creation to helper

* Lint

* Bumped version to 0.73.2
michaeldavie pushed a commit to michaeldavie/home-assistant that referenced this pull request Jul 31, 2018
* Extract SSL context creation to helper (home-assistant#15483)

* Extract SSL context creation to helper

* Lint

* Bumped version to 0.73.2
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Aug 5, 2018
* Extract SSL context creation to helper (home-assistant#15483)

* Extract SSL context creation to helper

* Lint

* Bumped version to 0.73.2
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Aug 31, 2018
* Extract SSL context creation to helper (home-assistant#15483)

* Extract SSL context creation to helper

* Lint

* Bumped version to 0.73.2
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
* Extract SSL context creation to helper

* Lint
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants