Doorbird auth and event data #16504
Closed
Doorbird auth and event data #16504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add video URLs as event data to make them available to event handlers and automations.
ghost
added
the
houndci-bot
reviewed
Sep 9, 2018
homeassistant/components/doorbird.py
Outdated
| @@ -126,16 +142,20 @@ def subscribe_events(hass, doorstation): | |||
|
|
|||
| doorstation.device.subscribe_notification(event_type, url) | |||
|
|
|||
| #Register a dummy listener so event is listed in GUI | |||
There was a problem hiding this comment.
block comment should start with '# '
homeassistant/components/doorbird.py
Outdated
| import voluptuous as vol | ||
|
|
||
| from homeassistant.components.http import HomeAssistantView | ||
| from homeassistant.components.http import KEY_AUTHENTICATED, HomeAssistantView |
There was a problem hiding this comment.
'homeassistant.components.http.KEY_AUTHENTICATED' imported but unused
2 tasks
houndci-bot
reviewed
Sep 9, 2018
2 tasks
houndci-bot
reviewed
Oct 21, 2018
homeassistant/components/doorbird.py
Outdated
|
|
||
| import asyncio |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Require token to be used as auth by Doorbird devices . Add video URLs as event data to make them available to event handlers and automations.
Related issue (if applicable): #15376
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#6245
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: