Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix faulty color temp crashing google #16758

Merged
merged 3 commits into from
Sep 21, 2018
Merged

Conversation

balloob
Copy link
Member

@balloob balloob commented Sep 20, 2018

Description:

Fix faulty color temp crashing Google Assistant sync

Related issue (if applicable): fixes #13381

Example entry for configuration.yaml (if applicable):

cloud:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@@ -457,6 +457,22 @@
}


async def test_color_temperature_light(hass):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redefinition of unused 'test_color_temperature_light' from line 404

@balloob
Copy link
Member Author

balloob commented Sep 21, 2018

We discussed in the chat if we should add the warning logic to the light component. I don't want to go down that road as it will add a lot more checks on runtime, slowing the system down. Instead, it's a good idea to build a component that will scan the history to see if states didn't match the expectations.

@balloob balloob merged commit df67093 into dev Sep 21, 2018
@balloob balloob deleted the fix-google-assistant-color-temp branch September 21, 2018 08:51
@ghost ghost removed the in progress label Sep 21, 2018
@balloob balloob mentioned this pull request Sep 28, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Assistant error when turning off color temp supported lights
5 participants