Add AWS Route53 Dynamic DNS support #17072

keirans · 2018-10-02T12:57:14Z

Description:

This component adds AWS Route53 dynamic DNS support.

I've tested this and updated the documentation accordingly.

This is my first real Python code, so go easy on me ;)

Example entry for `configuration.yaml` (if applicable):

route53:
  aws_access_key_id: ABC123
  aws_secret_access_key: DEF456
  zone: ZONEID678
  domain: example.domain.com
  records:
    - vpn
    - hassio
    - home

Checklist:

The code change is tested and works locally.
Local tests pass with tox.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.io
Route53 Documentation PR

If the code communicates with devices, web services, or third-party tools:

New dependencies have been added to the REQUIREMENTS variable (example).
New dependencies are only imported inside functions that use them (example).
New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
New files were added to .coveragerc.

If the code does not interact with devices:

Tests have been added to verify that the new code works.

houndci-bot · 2018-10-02T12:57:27Z

homeassistant/components/route53.py

+
+    if response['ResponseMetadata']['HTTPStatusCode'] is not 200:
+        _LOGGER.warning(response)
+


blank line at end of file

houndci-bot · 2018-10-02T12:57:27Z

homeassistant/components/route53.py

+        changes.append(
+            {
+                'Action' : 'UPSERT',
+                'ResourceRecordSet' : {


whitespace before ':'

houndci-bot · 2018-10-02T12:57:27Z

homeassistant/components/route53.py

+
+        changes.append(
+            {
+                'Action' : 'UPSERT',


whitespace before ':'

houndci-bot · 2018-10-02T12:57:28Z

homeassistant/components/route53.py

+        return
+
+    except:
+        _LOGGER.warning('The ipify logic in the route53 component failed and needs futher investigation')


line too long (105 > 79 characters)

homeassistant/components/route53.py

houndci-bot · 2018-10-02T12:57:28Z

homeassistant/components/route53.py

+        ipaddress = get_ip()
+
+    except ConnectionError:
+        _LOGGER.warning('Unable to reach the ipify service to most likely because of a network error on your end.')


line too long (115 > 79 characters)

houndci-bot · 2018-10-02T12:57:28Z

homeassistant/components/route53.py

+    return True
+
+
+def _update_route53(aws_access_key_id, aws_secret_access_key, zone, domain, records):


line too long (85 > 79 characters)

houndci-bot · 2018-10-02T12:57:28Z

homeassistant/components/route53.py

+
+    def update_records_service(now):
+        """Set up service for manual trigger."""
+        _update_route53(aws_access_key_id, aws_secret_access_key, zone, domain, records)


line too long (88 > 79 characters)

houndci-bot · 2018-10-02T12:57:28Z

homeassistant/components/route53.py

+
+    def update_records_interval(now):
+        """Set up recurring update."""
+        _update_route53(aws_access_key_id, aws_secret_access_key, zone, domain, records)


line too long (88 > 79 characters)

houndci-bot · 2018-10-02T12:57:28Z

homeassistant/components/route53.py

+import homeassistant.helpers.config_validation as cv
+from homeassistant.helpers.event import track_time_interval
+
+REQUIREMENTS = ['boto3==1.9.6', 'ipify==1.0.0' ]


whitespace before ']'

homeassistant/components/route53.py

houndci-bot · 2018-10-02T13:16:43Z

homeassistant/components/route53.py

+import homeassistant.helpers.config_validation as cv
+from homeassistant.helpers.event import track_time_interval
+
+REQUIREMENTS = ['boto3==1.9.6','ipify==1.0.0']


missing whitespace after ','

homeassistant · 2018-10-02T13:23:23Z

Hi @keirans,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

awarecan · 2018-10-02T17:29:04Z

Thanks for your contribution, however I didn't found the reason we need this as part of homeassistant, it is better fit for a hass.io add-on IMO.

keirans · 2018-10-02T21:28:29Z

Hey @awarecan,
Thanks for the review.

This is based on the cloudflare DNS component that is already part of home assistant, alongside duckdns/freedns and a number of other providers.

Given AWS is the biggest cloud provider out there today, it made sense for me to add it.

I have already got this as an add-on, however a number of people i know don't run it as hass, rather under docker directly, so they can't use the add-on.

Let me know what you think,

Cheers,

K

ludeeus · 2018-10-02T21:38:51Z

To be honest I disagree, I think this goes well in along side the other services we have like DuckDNS, Namecheap, google, freedns, no-ip, Cloudflare.
https://www.home-assistant.io/components/#network

homeassistant/components/route53.py

.coveragerc

keirans · 2018-10-07T06:44:50Z

Hey @fabaff , I've overhauled the code and tested it all works OK.

I've got all the outstanding CI issues resolved and it is ready for your approval and merge into dev.

Let me know if there are any other things i need to do.

Thanks :)

homeassistant/components/route53.py

homeassistant added cla-error new-platform integration: route53 labels Oct 2, 2018

ghost added the in progress label Oct 2, 2018

houndci-bot reviewed Oct 2, 2018

View reviewed changes

keirans mentioned this pull request Oct 2, 2018

Add Route53 component documentation home-assistant/home-assistant.io#6439

Merged

2 tasks

keirans force-pushed the route53 branch from 9cac57b to c0593e9 Compare October 2, 2018 13:16

houndci-bot reviewed Oct 2, 2018

View reviewed changes

keirans force-pushed the route53 branch from c0593e9 to 2082d8e Compare October 2, 2018 13:23

homeassistant added cla-needed cla-signed and removed cla-needed labels Oct 2, 2018

awarecan added cla-recheck and removed cla-error cla-signed labels Oct 2, 2018

homeassistant added cla-signed and removed cla-recheck labels Oct 2, 2018

bachya added the Hacktoberfest label Oct 2, 2018

home-assistant deleted a comment from homeassistant Oct 3, 2018

fabaff reviewed Oct 3, 2018

View reviewed changes

homeassistant/components/route53.py Show resolved Hide resolved

fabaff requested changes Oct 3, 2018

View reviewed changes

awarecan mentioned this pull request Oct 3, 2018

Refactor/Remove DNS components home-assistant/architecture#89

Closed

keirans force-pushed the route53 branch 3 times, most recently from 7ad7bab to b788db1 Compare October 7, 2018 05:57

keirans force-pushed the route53 branch from b788db1 to af6faff Compare October 8, 2018 23:37

houndci-bot reviewed Oct 8, 2018

View reviewed changes

homeassistant/components/route53.py Outdated Show resolved Hide resolved

keirans force-pushed the route53 branch 3 times, most recently from 03ceb4d to a8c73fd Compare October 13, 2018 03:46

Add AWS Route53 dynamic DNS support to Home Assistant

9c84961

keirans force-pushed the route53 branch from a8c73fd to 9c84961 Compare October 13, 2018 03:56

Remove line breaks

3158dd4

ghost assigned fabaff Oct 13, 2018

fabaff approved these changes Oct 13, 2018

View reviewed changes

fabaff merged commit 78e29cd into home-assistant:dev Oct 13, 2018

ghost removed the in progress label Oct 13, 2018

balloob mentioned this pull request Oct 26, 2018

0.81 #17809

Merged

home-assistant locked and limited conversation to collaborators Feb 5, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add AWS Route53 Dynamic DNS support #17072

Add AWS Route53 Dynamic DNS support #17072

keirans commented Oct 2, 2018

houndci-bot Oct 2, 2018

houndci-bot Oct 2, 2018

houndci-bot Oct 2, 2018

houndci-bot Oct 2, 2018

houndci-bot Oct 2, 2018

houndci-bot Oct 2, 2018

houndci-bot Oct 2, 2018

houndci-bot Oct 2, 2018

houndci-bot Oct 2, 2018

houndci-bot Oct 2, 2018

homeassistant commented Oct 2, 2018

awarecan commented Oct 2, 2018 •

edited

Loading

keirans commented Oct 2, 2018

ludeeus commented Oct 2, 2018 •

edited

Loading

keirans commented Oct 7, 2018 •

edited

Loading


		if response['ResponseMetadata']['HTTPStatusCode'] is not 200:
		_LOGGER.warning(response)

		return True


		def _update_route53(aws_access_key_id, aws_secret_access_key, zone, domain, records):

Add AWS Route53 Dynamic DNS support #17072

Add AWS Route53 Dynamic DNS support #17072

Conversation

keirans commented Oct 2, 2018

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

homeassistant commented Oct 2, 2018

awarecan commented Oct 2, 2018 • edited Loading

keirans commented Oct 2, 2018

ludeeus commented Oct 2, 2018 • edited Loading

keirans commented Oct 7, 2018 • edited Loading

Example entry for `configuration.yaml` (if applicable):

awarecan commented Oct 2, 2018 •

edited

Loading

ludeeus commented Oct 2, 2018 •

edited

Loading

keirans commented Oct 7, 2018 •

edited

Loading