Add additional property to HomeKitSwitch to show whether the Homekit outlet is in use #17448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
platform: switch.homekit_controller
small-pr
…outlet is in use or not
drndos
force-pushed
the
homekit-outlet-in-use
branch
from
e66758a
to
ec8ccfe
Compare
MartinHjelmare
requested changes
Oct 20, 2018
| @@ -62,3 +70,20 @@ def turn_off(self, **kwargs): | |||
| 'iid': self._chars['on'], | |||
| 'value': False}] | |||
| self.put_characteristics(characteristics) | |||
|
|
|||
| @property | |||
| def state_attributes(self): | |||
There was a problem hiding this comment.
This should be device_state_attributes.
There was a problem hiding this comment.
Ok so base entities are using state_attributes and platforms like homekit should use device_state_attributes. Is that correct ?
There was a problem hiding this comment.
Thank you very much for clarification. I am just learning how to contribute and use things properly. I appreciate your time and help :)
| return data | ||
|
|
||
| @property | ||
| def outlet_in_use(self): |
There was a problem hiding this comment.
We don't need a property. Just assign to a regular instance attribute.
| """Return the optional state attributes.""" | ||
| data = {} | ||
|
|
||
| for prop, attr in PROP_TO_ATTR.items(): |
There was a problem hiding this comment.
If it's only one attribute we don't need a dict or use getattr. Keep it simple for now.
…the device_state_attributes method
MartinHjelmare
approved these changes
Oct 21, 2018
Merged
ghost
added
integration: homekit_controller
and removed
platform: switch.homekit_controller
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request adds a feature where you get additional property to your switch that is representing Homekit outlet indicating whether the actual outlet is in use or not. Tested on Koogeek P1EU and working.
Related issue (if applicable):
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: