Fix unhandled exception which creates many useless logs #17508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
platform: media_player.horizon
small-pr
ghost
added
the
balloob
requested changes
Oct 16, 2018
| self._state = STATE_PLAYING | ||
| else: | ||
| try: | ||
| if self._client.is_powered_on(): |
There was a problem hiding this comment.
This is changing the logic, now if is_powered_on is false, we are not resetting the state to off.
There was a problem hiding this comment.
ah sorry! for the specific issue this PR resolves it would make no difference but you are totally right. this was not the right way and bad style. I think I found a more elegant solution 👍
balloob
reviewed
Oct 16, 2018
| else: | ||
| try: | ||
| self._state = (STATE_PLAYING | ||
| if self._client.is_powered_on() |
There was a problem hiding this comment.
Please don't use inline if statement, they are not very readable
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes unhandled exception in horizon component.
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: