Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bloomsky api call #18016

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Conversation

dshokouhi
Copy link
Member

Description:

After 0.81.2 the requests module was updated to v2.20.0 which removes the authorization header from HTTPS to HTTP redirects for the same base URL. The Bloomksy API was previously using HTTPS however it was being redirected to HTTP. This updates the API URL to use one that is accepted.

psf/requests#4835 3rd bullet point

Related issue (if applicable): fixes #18014

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io# N/A

Example entry for configuration.yaml (if applicable):

bloomsky:
  api_key: apikey

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@ghost ghost added the in progress label Oct 30, 2018
@ludeeus
Copy link
Member

ludeeus commented Oct 30, 2018

👍

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐦

@fabaff fabaff merged commit 9cb5ea2 into home-assistant:dev Oct 30, 2018
@ghost ghost removed the in progress label Oct 30, 2018
@dshokouhi dshokouhi deleted the fix_bloomsky_api_call branch October 30, 2018 20:25
@balloob balloob mentioned this pull request Nov 9, 2018
@dshokouhi dshokouhi mentioned this pull request Nov 21, 2018
3 tasks
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bloomsky fails to initialize after 0.81.2
4 participants