New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bloomsky api call #18016

Merged
merged 1 commit into from Oct 30, 2018

Conversation

Projects
None yet
4 participants
@dshokouhi
Contributor

dshokouhi commented Oct 30, 2018

Description:

After 0.81.2 the requests module was updated to v2.20.0 which removes the authorization header from HTTPS to HTTP redirects for the same base URL. The Bloomksy API was previously using HTTPS however it was being redirected to HTTP. This updates the API URL to use one that is accepted.

requests/requests#4835 3rd bullet point

Related issue (if applicable): fixes #18014

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io# N/A

Example entry for configuration.yaml (if applicable):

bloomsky:
  api_key: apikey

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
@ludeeus

This comment has been minimized.

Member

ludeeus commented Oct 30, 2018

👍

@fabaff

fabaff approved these changes Oct 30, 2018

🐦

@fabaff fabaff merged commit 9cb5ea2 into home-assistant:dev Oct 30, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.02%
Details

@wafflebot wafflebot bot removed the in progress label Oct 30, 2018

@dshokouhi dshokouhi deleted the dshokouhi:fix_bloomsky_api_call branch Oct 30, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

@dshokouhi dshokouhi referenced this pull request Nov 21, 2018

Merged

Upgrade requests to 2.20.1 #18615

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment