Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mill room temp #18203

Merged
merged 3 commits into from
Nov 5, 2018
Merged

Mill room temp #18203

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5dc4e52
mill, avg room temp
Nov 4, 2018
9e66c3d
typo
Danielhiversen Nov 4, 2018
81b6ed3
Mill device_state_attributes
Danielhiversen Nov 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion homeassistant/components/climate/mill.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
from homeassistant.helpers import config_validation as cv
from homeassistant.helpers.aiohttp_client import async_get_clientsession

REQUIREMENTS = ['millheater==0.2.2']
REQUIREMENTS = ['millheater==0.2.3']

_LOGGER = logging.getLogger(__name__)

Expand Down Expand Up @@ -114,13 +114,16 @@ def device_state_attributes(self):
"""Return the state attributes."""
if self._heater.room:
room = self._heater.room.name
avg_room_temp = self._heater.room.avg_temp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be the value returned from current_temperature ?

Copy link
Member Author

@Danielhiversen Danielhiversen Nov 4, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you can have several heaters in one room (Defined by Mill app). This will be the average temperature for all heaters in that room.

else:
room = "Independent device"
avg_room_temp = None
return {
"room": room,
"open_window": self._heater.open_window,
"heating": self._heater.is_heating,
"controlled_by_tibber": self._heater.tibber_control,
"avg_room_temp": avg_room_temp,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually don't populate device state attributes with items where the value is None. Maybe we should check that here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so if it is None, we do not add it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's an existing pattern.

}

@property
Expand Down
2 changes: 1 addition & 1 deletion requirements_all.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,7 +619,7 @@ mficlient==0.3.0
miflora==0.4.0

# homeassistant.components.climate.mill
millheater==0.2.2
millheater==0.2.3

# homeassistant.components.sensor.mitemp_bt
mitemp_bt==0.0.1
Expand Down