New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect Alexa Smart Home API v3 name change for additionalApplianceDetails #18485

Merged
merged 1 commit into from Nov 15, 2018

Conversation

Projects
None yet
3 participants
@pc-coholic
Contributor

pc-coholic commented Nov 15, 2018

Description:

The v3 payload for the Alexa Smart Home API changes the name of the additionalApplianceDetails property to cookie.

As additionalApplianceDetails (or cookie) is not being used at this time, there aren't any (breaking) changes to be expected. This is more of a future-proofing of the payload for future developments.

Validation/Reference for this API change: https://developer.amazon.com/blogs/alexa/post/87c5cf67-1f27-42d3-a07a-e4f559674392/how-to-migrate-your-alexa-skill-to-the-updated-smart-home-skill-api

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
@homeassistant

This comment has been minimized.

homeassistant commented Nov 15, 2018

Hi @pc-coholic,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@wafflebot wafflebot bot added the in progress label Nov 15, 2018

@homeassistant homeassistant added cla-signed and removed cla-needed labels Nov 15, 2018

@bachya bachya merged commit b7b8296 into home-assistant:dev Nov 15, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot All contributors have signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.046%
Details

@wafflebot wafflebot bot removed the in progress label Nov 15, 2018

@bachya

This comment has been minimized.

Contributor

bachya commented Nov 15, 2018

Thanks! 😎

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment