Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve real time subscription for Tibber Pulse #18517

Merged
merged 1 commit into from
Nov 16, 2018
Merged

Improve real time subscription for Tibber Pulse #18517

merged 1 commit into from
Nov 16, 2018

Conversation

Danielhiversen
Copy link
Member

Description:

Improve real time consumption for Tibber sensor.
https://github.com/Danielhiversen/pyTibber/commits/master

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@ghost ghost assigned Danielhiversen Nov 16, 2018
@ghost ghost added the in progress label Nov 16, 2018
@cgarwood cgarwood merged commit 6b2f50b into dev Nov 16, 2018
@ghost ghost removed the in progress label Nov 16, 2018
@Danielhiversen Danielhiversen changed the title Improve real time consumption for Tibber sensor Improve real time subscription for Tibber Pulse Nov 18, 2018
@Danielhiversen Danielhiversen deleted the tibber_rt branch November 18, 2018 10:51
@balloob balloob mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Danielhiversen Danielhiversen

Labels
cla-signed integration: tibber small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Danielhiversen @cgarwood @homeassistant