Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /sbin to launchd PATH #18601

Merged
merged 2 commits into from
Nov 21, 2018
Merged

Add /sbin to launchd PATH #18601

merged 2 commits into from
Nov 21, 2018

Conversation

andersonshatch
Copy link
Contributor

Description:

On macOS, ping resides in /sbin, so when running hass with launchd, it needs to be available on the PATH for ping sensors to function

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

binary_sensor:
  - platform: ping
    host: 192.168.0.1

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@homeassistant homeassistant added cla-signed core small-pr PRs with less than 30 lines. labels Nov 20, 2018
@ghost ghost added the in progress label Nov 20, 2018
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I'm not a macOS user.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/sbin should be further down the path. E.g., the user should be able to override an executable in the lookup path by placing a program in /usr/local/bin for example.

homeassistant/scripts/macos/launchd.plist Outdated Show resolved Hide resolved
Co-Authored-By: andersonshatch <andersonshatch@gmail.com>
@balloob balloob merged commit 3d17870 into home-assistant:dev Nov 21, 2018
@ghost ghost removed the in progress label Nov 21, 2018
@balloob balloob mentioned this pull request Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants