Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small refactoring of MQTT cover #18850

Merged
merged 1 commit into from
Dec 2, 2018
Merged

Small refactoring of MQTT cover #18850

merged 1 commit into from
Dec 2, 2018

Conversation

emontnemery
Copy link
Contributor

Description:

Small refactoring of MQTT cover as proposed in #18174:

  • Just store config instead of every variable since the configuration values are just copied.

(Follow-up to #18674)

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@ghost ghost assigned emontnemery Nov 30, 2018
@ghost ghost added the in progress label Nov 30, 2018
@balloob balloob merged commit db4a0e3 into home-assistant:dev Dec 2, 2018
@ghost ghost removed the in progress label Dec 2, 2018
@emontnemery emontnemery deleted the mqtt_cover_refactor branch December 2, 2018 16:28
@balloob balloob mentioned this pull request Dec 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balloob balloob balloob approved these changes

Assignees

@emontnemery emontnemery

Labels
cla-signed integration: mqtt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emontnemery @balloob @homeassistant