WIP: Support for sections for Fibaro hub integration #18981
Conversation
ghost
added
the
| @@ -54,6 +55,7 @@ | |||
| vol.Required(CONF_USERNAME): cv.string, | |||
| vol.Required(CONF_URL): cv.url, | |||
| vol.Optional(CONF_PLUGINS, default=False): cv.boolean, | |||
| vol.Optional(CONF_SECTIONS, default=False): cv.boolean, | |||
There was a problem hiding this comment.
Why does it need to be configurable?
There was a problem hiding this comment.
if you have a big house, it's nicer to have the section names appended, so you don't end up with two devices with the friendly name being "Bathroom lights". But if you don't have a big house, it's more a drag, because every device will be like "First Floor Bathr..." in most views. Once I added section support, I realized that I don't like it myself, but heard back from people who would appreciate it. So it's a tough call. I don't like too many options either.
There was a problem hiding this comment.
After unique id feature, users can quite easily change name and entity_id. Do you still think we need to be able to turn sections off?
There was a problem hiding this comment.
I would have it off by default, but someone with a big house usually would have 100+ devices, renaming those would be a major pain. This option also affects the unique id, to keep the lovelace ui definition file readable as well. I really can see both camps going to a lot of pain and frustration without this flag.
There was a problem hiding this comment.
Once we'll have area support, I'll map the whole section/room info into areas and then the device name can be the device name. For now, I think it's still the best option however.
|
That end in a breaking change after home-assistant/architecture#94 is implemented. Let's invest the time, not in workarounds and try to apply this architecture change. More options also not help to achieve it later to config flow or make it user-friendly. If you implement the |
pbalogh77
changed the title
|
@pvizeli I've put it on hold for now. I've implemented unique ID in a new PR. I'll do the config flow implementation first and come back to this after that. Thanks for the feedback from you and @MartinHjelmare |
This comment has been minimized.
This comment has been minimized.
|
Areas have been implemented now, I don't think this PR is needed anymore? |
|
Closing this PR as we now have areas. |
Description:
Support for naming devices based on section + room + device name for Fibaro hub integrations. This can be useful for people with large houses.
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed: