Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyvizio version in vizio.py #19048

Merged
merged 3 commits into from
Dec 5, 2018
Merged

Bump pyvizio version in vizio.py #19048

merged 3 commits into from
Dec 5, 2018

Conversation

photinus
Copy link
Contributor

@photinus photinus commented Dec 5, 2018

Bump pyvizio version to resolve get volume call and component setup failures

Description:

Related issue (if applicable): fixes #18577

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Bump pyvizio version to reoslve get volume call and component setup failures
@homeassistant
Copy link
Contributor

Hi @photinus,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Copy link
Member

@cgarwood cgarwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run script/gen_requirements_all.py to update the requirements_all.txt file and include that in this PR

@photinus photinus reopened this Dec 5, 2018
@ghost ghost added the in progress label Dec 5, 2018
Copy link
Member

@cgarwood cgarwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can be merged when build passes

@cgarwood cgarwood merged commit 0aee355 into home-assistant:dev Dec 5, 2018
@ghost ghost removed the in progress label Dec 5, 2018
@balloob balloob mentioned this pull request Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vizio Component has stopped working
3 participants