New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sunrise and sunset to Darksky weather sensor #19492

Merged
merged 2 commits into from Dec 22, 2018

Conversation

Projects
None yet
4 participants
@fabaff
Copy link
Member

fabaff commented Dec 20, 2018

Description:

Add sunrise and sunset to Darksky weather sensor.

Related issue (if applicable): fixes 85438

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7917

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: darksky
    api_key: !secret darksky_api
    forecast:
      - 0
    monitored_conditions:
      - sunrise_time
      - sunset_time

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

@fabaff fabaff referenced this pull request Dec 20, 2018

Merged

Add sunset and sunrise #7917

2 of 2 tasks complete

@cgarwood cgarwood merged commit 6880be5 into dev Dec 22, 2018

6 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on darksky-sun at 93.043%
Details

@delete-merged-branch delete-merged-branch bot deleted the darksky-sun branch Dec 22, 2018

@wafflebot wafflebot bot removed the in progress label Dec 22, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Add sunrise and sunset to Darksky weather sensor (home-assistant#19492)
* Add sunrise and sunset to Darksky weather sensor

* Fix lint issue

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment