Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for triggered state on NX584 alarm. #19524

Merged
merged 2 commits into from
Dec 25, 2018
Merged

Added support for triggered state on NX584 alarm. #19524

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
804578e
Added support for triggered state on NX584 alarm.
mreiling Dec 22, 2018
d726d9f
Minor update
fabaff Dec 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions homeassistant/components/alarm_control_panel/nx584.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
from homeassistant.components.alarm_control_panel import PLATFORM_SCHEMA
from homeassistant.const import (
CONF_HOST, CONF_NAME, CONF_PORT, STATE_ALARM_ARMED_AWAY,
STATE_ALARM_ARMED_HOME, STATE_ALARM_DISARMED, STATE_UNKNOWN)
STATE_ALARM_ARMED_HOME, STATE_ALARM_DISARMED, STATE_ALARM_TRIGGERED)
import homeassistant.helpers.config_validation as cv

REQUIREMENTS = ['pynx584==0.4']
Expand Down Expand Up @@ -43,7 +43,7 @@ def setup_platform(hass, config, add_entities, discovery_info=None):
add_entities([NX584Alarm(hass, url, name)])
except requests.exceptions.ConnectionError as ex:
_LOGGER.error("Unable to connect to NX584: %s", str(ex))
return False
return


class NX584Alarm(alarm.AlarmControlPanel):
Expand All @@ -60,7 +60,7 @@ def __init__(self, hass, url, name):
# talk to the API and trigger a requests exception for setup_platform()
# to catch
self._alarm.list_zones()
self._state = STATE_UNKNOWN
self._state = None

@property
def name(self):
Expand All @@ -85,11 +85,11 @@ def update(self):
except requests.exceptions.ConnectionError as ex:
_LOGGER.error("Unable to connect to %(host)s: %(reason)s",
dict(host=self._url, reason=ex))
self._state = STATE_UNKNOWN
self._state = None
zones = []
except IndexError:
_LOGGER.error("NX584 reports no partitions")
self._state = STATE_UNKNOWN
self._state = None
zones = []

bypassed = False
Expand All @@ -107,6 +107,10 @@ def update(self):
else:
self._state = STATE_ALARM_ARMED_AWAY

for flag in part['condition_flags']:
if flag == "Siren on":
self._state = STATE_ALARM_TRIGGERED

def alarm_disarm(self, code=None):
"""Send disarm command."""
self._alarm.disarm(code)
Expand Down