New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support knx operation types #19546
Support knx operation types #19546
Conversation
/cc @Julius2342 |
Adjusted climate component due to changes in the underlying library.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't accept this until the correct operation modes are used for the home assistant user interface, ie current_operation
, operation_list
and async_set_operation_mode
.
@MartinHjelmare: Thank you for reviewing this. I think I've addressed all review comments. One thing I'm not sure about is the mapping of the operation modes. I'm not particularly happy with some of the mappings since they don't fit the HA operation modes completly. Also we can't support all operation modes. I think this is ok for now and I'll take care of that at a later stage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Please add a paragraph in the PR description about the breaking change for the release notes. |
@MartinHjelmare I added the paragraph in the PR description. |
I tweaked the message a bit. Please make sure to mention in the docs how the mapping is done between home assistant operation mode and knx mode. |
Description:
Updated xknx version to 0.9.3
Adjusted climate component due to changes in the underlying library.
Release notes
Refactored climate component to be able to support operation types. See the documentation for the new operation modes.
Related issue (if applicable): fixes #14531
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7937
Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices: