New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support knx operation types #19546

Merged
merged 4 commits into from Dec 29, 2018

Conversation

Projects
None yet
5 participants
@marvin-w
Copy link
Contributor

marvin-w commented Dec 23, 2018

Description:

Updated xknx version to 0.9.3
Adjusted climate component due to changes in the underlying library.

Release notes

  • Breaking change:
    Refactored climate component to be able to support operation types. See the documentation for the new operation modes.
  • the lovelace climate card can now be used with a knx climate device
  • fixed a bug where updating the operation mode wouldn't update the lovelace climate card

Related issue (if applicable): fixes #14531

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7937

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@homeassistant

This comment has been minimized.

Copy link

homeassistant commented Dec 23, 2018

Hi @marvin-w,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@homeassistant homeassistant added cla-signed and removed cla-needed labels Dec 23, 2018

@marvin-w

This comment has been minimized.

Copy link
Contributor

marvin-w commented Dec 23, 2018

@marvin-w marvin-w referenced this pull request Dec 23, 2018

Merged

Updated docs of knx climate device #7937

2 of 2 tasks complete

@marvin-w marvin-w force-pushed the marvin-w:feature/xknx-bumped-to-latest branch 2 times, most recently from 0eb6216 to 526484c Dec 23, 2018

@marvin-w marvin-w changed the title [WIP][Component.KNX] Updated version to 0.9.3 [Component.KNX] Updated version to 0.9.3 Dec 23, 2018

Show resolved Hide resolved homeassistant/components/climate/knx.py Outdated
Show resolved Hide resolved homeassistant/components/climate/knx.py Outdated
Updated version to 0.9.3
Adjusted climate component due to changes in the underlying library.

@marvin-w marvin-w force-pushed the marvin-w:feature/xknx-bumped-to-latest branch 2 times, most recently from 0e1926a to 2223421 Dec 24, 2018

@marvin-w marvin-w force-pushed the marvin-w:feature/xknx-bumped-to-latest branch from 2223421 to 60626ac Dec 24, 2018

@marvin-w marvin-w changed the title [Component.KNX] Updated version to 0.9.3 Updated xknx version to 0.9.3 Dec 24, 2018

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

We can't accept this until the correct operation modes are used for the home assistant user interface, ie current_operation, operation_list and async_set_operation_mode.

Show resolved Hide resolved homeassistant/components/climate/knx.py Outdated
Show resolved Hide resolved homeassistant/components/climate/knx.py Outdated
Show resolved Hide resolved homeassistant/components/climate/knx.py Outdated
Show resolved Hide resolved homeassistant/components/climate/knx.py Outdated
Show resolved Hide resolved homeassistant/components/climate/knx.py Outdated
Show resolved Hide resolved homeassistant/components/climate/knx.py
Show resolved Hide resolved homeassistant/components/climate/knx.py Outdated
Show resolved Hide resolved homeassistant/components/climate/knx.py
@marvin-w

This comment has been minimized.

Copy link
Contributor

marvin-w commented Dec 25, 2018

@MartinHjelmare: Thank you for reviewing this. I think I've addressed all review comments. One thing I'm not sure about is the mapping of the operation modes. I'm not particularly happy with some of the mappings since they don't fit the HA operation modes completly.

Also we can't support all operation modes. I think this is ok for now and I'll take care of that at a later stage.

@farmio farmio referenced this pull request Dec 29, 2018

Open

update light.knx for xknx 0.9.4 #7979

2 of 2 tasks complete

@marvin-w marvin-w force-pushed the marvin-w:feature/xknx-bumped-to-latest branch from a2f41a2 to cf658fa Dec 29, 2018

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Great!

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Dec 29, 2018

Please add a paragraph in the PR description about the breaking change for the release notes.

@marvin-w

This comment has been minimized.

Copy link
Contributor

marvin-w commented Dec 29, 2018

@MartinHjelmare I added the paragraph in the PR description.

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Dec 29, 2018

I tweaked the message a bit. Please make sure to mention in the docs how the mapping is done between home assistant operation mode and knx mode.

@MartinHjelmare MartinHjelmare changed the title Updated xknx version to 0.9.3 Support knx operation types Dec 29, 2018

@MartinHjelmare MartinHjelmare merged commit 338077f into home-assistant:dev Dec 29, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.02%) to 93.054%
Details

@wafflebot wafflebot bot removed the in progress label Dec 29, 2018

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 30, 2018

Merge branch 'dev' into current
* dev: (44 commits)
  Fix ADS light when parameter adsvar_brightness is not set (home-assistant#19636)
  Bump pyHik library to 0.1.9 to improve device support. (home-assistant#19656)
  Use aioharmony for remote.harmony platform (home-assistant#19595)
  Add RaspyRFM switch platform (home-assistant#19130)
  Only bind clusters in ZHA remote entity (home-assistant#19577)
  Use async_configure for ZHA IAS binary sensor (home-assistant#19629)
  Improve Wemo setup speed (home-assistant#19563)
  Support knx operation types (home-assistant#19546)
  Use xml.etree through defusedxml (home-assistant#19640)
  Fix cpu_temp issue on Vero 4K (home-assistant#19638)
  Added events STARTED, RESTARTED AND PAUSED (home-assistant#19516)
  Revert "Bump pyotgw to 0.4b0 (home-assistant#19618)" (home-assistant#19635)
  Upgrade to async_upnp_client==0.13.8 (home-assistant#19634)
  Upgraded pyarlo to 0.2.3 (home-assistant#19626)
  Fix cpu_temp issue on Odroid (home-assistant#19620)
  Bump pyotgw to 0.4b0 (home-assistant#19618)
  Add additional neato alerts and errors (home-assistant#19608)
  LCN component and light platform (home-assistant#18621)
  Systemmonitor - add device_class property (home-assistant#19614)
  Upgrade huawei-lte-api to 1.1.1 (home-assistant#19615)
  ...

@marvin-w marvin-w deleted the marvin-w:feature/xknx-bumped-to-latest branch Dec 30, 2018

@farmio farmio referenced this pull request Jan 6, 2019

Open

KNX : Light RGB #18620

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment