-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added regexp validation allowing Twilio notifications to use Sender ID instead of phone number #19644
Added regexp validation allowing Twilio notifications to use Sender ID instead of phone number #19644
Conversation
…D instead of phone number
Update the SMS configuration documentation with Sender ID as proposed in this PR: home-assistant/core#19644
@psvanstrom, could you please update the requirement in a different PR as you have a working Twilio setup to test it? Thanks |
@fabaff I'd love to, but I don't really understand what you mean with "update the requirement"? 😄 This is my first PR in home-assistant so I might have missed something obvious? |
The Twilio component ( Change the requirement ( |
Ah ok, will do that! Is it ok if I do that in this PR or should it be in a separate one? |
Please create a new PR. Easier to keep track of changes if there is one per PR and the IPv6 support seems to be independent from an upgrade to the Twilio Python module. |
Update the SMS configuration documentation with Sender ID as proposed in this PR: home-assistant/core#19644
…D instead of phone number (home-assistant#19644) * Added regexp validation allowing Twilio notifications to use Sender ID instead of phone number * Fix line length
Description:
Twilio now supports alphanumerical sender IDs to be used when sending SMS, see https://support.twilio.com/hc/en-us/articles/223181348-Getting-started-with-Alphanumeric-Sender-ID for more information. Sender IDs are available for all paid Twilio accounts and are supported in most countries.
The upside of using sender IDs instead of phone numbers is that you don't have to subscribe to a phone number, the only cost when sending SMS messages will be the actual fee for the message.
This PR updates the regular expression validating the
from_number
configuration parameter so that it allows both phone numbers as well as sender IDs, by applying the rules enforced by Twilio:Example entry for
configuration.yaml
:Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7980