Homekit controller garage cover support #19668
Conversation
added Mapping from Homekit type garage-door-opener to component Cover.
Implemented homekit-controller for cover compoment
removed commented code to comply with PR approval checklist
|
Hi @rudgr-duplicate, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
ghost
added
the
| @property | ||
| def supported_features(self): | ||
| """Flag supported features.""" | ||
| return SUPPORT_OPEN | SUPPORT_CLOSE | SUPPORT_STOP |
| @property | ||
| def available(self): | ||
| """Return True if entity is available.""" | ||
| return not self._door_state_current in [STATE_UNKNOWN] |
There was a problem hiding this comment.
test for membership should be 'not in'
| self.put_characteristics(characteristics) | ||
|
|
||
|
|
||
| @property |
|
|
||
| def stop_cover(self, **kwargs): | ||
| """Stop the cover.""" | ||
| if self._door_state_current not in [STATE_STOPPED, STATE_OPEN, STATE_CLOSED]: |
There was a problem hiding this comment.
line too long (85 > 79 characters)
| if self._door_state_current in [STATE_UNKNOWN]: | ||
| return None | ||
| return self._door_state_current in [STATE_CLOSED] | ||
|
|
|
|
||
| if ctype == "door-state.current": | ||
| self._chars['door-state.current'] = characteristic['iid'] | ||
| self._door_state_current = MODE_HOMEKIT_TO_HASS.get(characteristic['value']) |
There was a problem hiding this comment.
line too long (92 > 79 characters)
| accessory = hass.data[KNOWN_ACCESSORIES][discovery_info['serial']] | ||
| add_entities([HomeKitCover(accessory, discovery_info)], True) | ||
|
|
||
| class HomeKitCover(HomeKitEntity, CoverDevice): |
| # Map of hass operation modes to homekit modes | ||
| MODE_HASS_TO_HOMEKIT = {v: k for k, v in MODE_HOMEKIT_TO_HASS.items()} | ||
|
|
||
| def setup_platform(hass, config, add_entities, discovery_info=None): |
| from homeassistant.components.cover import (CoverDevice, SUPPORT_OPEN, SUPPORT_CLOSE, SUPPORT_STOP) | ||
| from homeassistant.const import ( | ||
| STATE_UNKNOWN, STATE_CLOSED, STATE_OPEN, STATE_CLOSING, STATE_OPENING) | ||
|
|
|
|
||
| from homeassistant.components.homekit_controller import (HomeKitEntity, | ||
| KNOWN_ACCESSORIES) | ||
| from homeassistant.components.cover import (CoverDevice, SUPPORT_OPEN, SUPPORT_CLOSE, SUPPORT_STOP) |
There was a problem hiding this comment.
line too long (99 > 79 characters)
removed empty lines
|
Hi @rudgr-duplicate, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
test for membership should be 'not in'
|
Hi @rudgr-duplicate, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
|
hmmm, for some reason github created my commits under @rudgr-duplicate instead of @rudgr ... so cannot sign the CLA :( |
re-formatted imports
|
Hi @rudgr-duplicate, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
|
Hi @rudgr-duplicate, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
fabaff
changed the title
|
Could not find a related documentation PR in our documentation repository, regarding this change. |
After fixing your git config email and github email, you can rebase your commits with the correct author information. Please turn to google or github support pages for best help, as this is not a problem specific to home assistant. |
|
Tx, seems to be an old duplicate Github account indeed, Github support is working on deleting it, after that, I Will resubmit the PR, including documentation ;-) |
|
Maybe you want to review the other PR and help get it merged? |
|
sorry @MartinHjelmare , my HA instance died, so I needed the time to setup everything again, great to see the other PR is merged, can't wait for HA v 0.86 :) |
Description:
https://community.home-assistant.io/t/control-homekit-enabled-garage-door-from-homeassistant/87722
https://community.home-assistant.io/t/add-garage-door-opener-device-type-support-to-homekit-controller/87723
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):not applicableChecklist:
tox. Your PR cannot be merged unless tests pass > sorry newbie here, don't know how to run the tests yet :)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: