New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zone and reps for Xiaomi vacuum #19777
Conversation
Hi @marcogazzola, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
Hi @marcogazzola, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a very brief review, hopefully someone else will also chime in to review this.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please do me a favor and update the log messages. :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last comment, I think. Then we should be good after the merge conflict is solved.
…sistant into dev" This reverts commit e1f370b3b45d2541c8117146b0940d7c2b5bc8b0.
The branch is polluted. Either try to fix it or open a new PR. |
I'm sorry.. |
* upstream/dev: (948 commits) Prevent partial custom component overlays (home-assistant#21070) Alarm trigger support for Point (home-assistant#21207) Upgrade opensensemap-api to 0.1.4 (home-assistant#21240) Remove constraint from regex (home-assistant#21239) Updated frontend to 20190220.0 Support OpenWRT 18.06 in luci device tracker (home-assistant#21236) Bump zigpy (home-assistant#21203) Fix bug in ZHA and tweak non sensor channel logic (home-assistant#21234) Don't dispatch to components when there are no channels for ZHA sensors (home-assistant#21223) Add zone and reps for Xiaomi vacuum (home-assistant#19777) Fix an Ambient PWS exception when location info is missing (home-assistant#21220) Add self to integration sensor and utility_meter (home-assistant#21226) Prevent invalid context from crashing (home-assistant#21231) Update pyhomematic to 0.1.56 (home-assistant#21227) Fix the build (home-assistant#21229) Updated frontend to 20190219.0 Add yeelight flow action support (home-assistant#21195) Refactor ZHA listeners into channels (home-assistant#21196) Fix Homematic IP Cloud configuration (home-assistant#21202) Push pyads to 3.0.7 (home-assistant#21216) ...
Description:
Add functionality to clean a specific zone and set the number of repetitions with Xiaomi Vacuum
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8047
Declare the data_template parameter for using templating repeats parameter.
Example entry for
automation.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices: