New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom and zone cleaning to Neato Vacuums #20779
Conversation
I think this looks good! Before merge, we should verify under what domain we want to register the service. |
I posted on #devs_backend about the service domain, but no answer so far. Also depending on the decision, I'll have to update the documentation accordingly. |
@MartinHjelmare any news on the service domain? |
I just noticed that Xiaomi had their zone cleaning service under |
Then we have to change it again. 😢 |
1b7e938
to
42748f9
Compare
Done in the latest force-push (conflicts resolution). I'm going to update the documentation accordingly. |
Can be merged when build passes. |
I want to make my website Goklean4u user-friendly, which is the best service that I can use. |
Description:
Adding custom cleaning and zone cleaning to the neato vacuum
Credits for the initial custom_component with beta zone cleaning support to @dshokouhi
#19835 can be closed in favor of this one.
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8421
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices: