Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom and zone cleaning to Neato Vacuums #20779

Merged
merged 16 commits into from Feb 23, 2019

Conversation

RomRider
Copy link
Contributor

@RomRider RomRider commented Feb 6, 2019

Description:

Adding custom cleaning and zone cleaning to the neato vacuum

Credits for the initial custom_component with beta zone cleaning support to @dshokouhi
#19835 can be closed in favor of this one.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8421

Example entry for configuration.yaml (if applicable):

neato:
  username: !secret neato_username
  password: !secret neato_password

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

homeassistant/components/neato/vacuum.py Outdated Show resolved Hide resolved
homeassistant/components/neato/vacuum.py Outdated Show resolved Hide resolved
homeassistant/components/neato/vacuum.py Outdated Show resolved Hide resolved
homeassistant/components/neato/vacuum.py Outdated Show resolved Hide resolved
homeassistant/components/neato/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/neato/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/neato/vacuum.py Outdated Show resolved Hide resolved
homeassistant/components/neato/vacuum.py Outdated Show resolved Hide resolved
@home-assistant home-assistant deleted a comment from houndci-bot Feb 6, 2019
homeassistant/components/neato/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/neato/vacuum.py Outdated Show resolved Hide resolved
@MartinHjelmare MartinHjelmare changed the title Adding custom and zone cleaning to Neato Vacuums Add custom and zone cleaning to Neato Vacuums Feb 6, 2019
@home-assistant home-assistant deleted a comment from houndci-bot Feb 7, 2019
homeassistant/components/neato/vacuum.py Outdated Show resolved Hide resolved
homeassistant/components/neato/vacuum.py Outdated Show resolved Hide resolved
homeassistant/components/vacuum/services.yaml Outdated Show resolved Hide resolved
@MartinHjelmare
Copy link
Member

I think this looks good! Before merge, we should verify under what domain we want to register the service.

@RomRider
Copy link
Contributor Author

RomRider commented Feb 8, 2019

I posted on #devs_backend about the service domain, but no answer so far. Also depending on the decision, I'll have to update the documentation accordingly.

@RomRider
Copy link
Contributor Author

@MartinHjelmare any news on the service domain?

@MartinHjelmare
Copy link
Member

MartinHjelmare commented Feb 14, 2019

@balloob? ☝️

#20779 (comment)

@dshokouhi
Copy link
Member

I just noticed that Xiaomi had their zone cleaning service under vacuum so maybe for consistency we leave it under vacuum? This PR was just recently merged: #19777

@MartinHjelmare
Copy link
Member

Then we have to change it again. 😢

@RomRider
Copy link
Contributor Author

Then we have to change it again. 😢

Done in the latest force-push (conflicts resolution). I'm going to update the documentation accordingly.

@MartinHjelmare
Copy link
Member

Can be merged when build passes.

@abrahambyneni
Copy link

I want to make my website Goklean4u user-friendly, which is the best service that I can use.

@balloob balloob mentioned this pull request Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants