Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HomematicIP update version to 0.10.1 #19788

Merged
merged 2 commits into from
Jan 5, 2019
Merged

HomematicIP update version to 0.10.1 #19788

merged 2 commits into from
Jan 5, 2019

Conversation

worm-ee
Copy link
Contributor

@worm-ee worm-ee commented Jan 5, 2019

Description:

Update rest-api version to 0.10.1.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@worm-ee
Copy link
Contributor Author

worm-ee commented Jan 5, 2019

@MartinHjelmare I would need your help :-)
I increased the REQUIREMENT version of the 3rd-party-lib but script/gen_requirements_all.py is not updating the file!? Any advice?

Thanks Mattias

@MartinHjelmare
Copy link
Member

Any errors when running the script?

@worm-ee
Copy link
Contributor Author

worm-ee commented Jan 5, 2019

Yes, but not related to HomematicIP :-|

$ script/gen_requirements_all.py
******* ERROR
Errors while importing: homeassistant.components.climate.econet, homeassistant.components.device_tracker.owntracks_http, homeassistant.components.google_assistant.auth, homeassistant.components.light.mqtt_json, homeassistant.components.light.mqtt_template, homeassistant.components.upnp.config_flow
Make sure you import 3rd party libraries inside methods.

@MartinHjelmare
Copy link
Member

Try running script/setup first.

@worm-ee
Copy link
Contributor Author

worm-ee commented Jan 5, 2019

Thanks!

@MartinHjelmare MartinHjelmare merged commit 3d0c3ab into home-assistant:dev Jan 5, 2019
@ghost ghost removed the in progress label Jan 5, 2019
@anrada73
Copy link

Hi, can we hope to add new Homematic Ip devices soon? Many people are waiting for the HMIP Froll/Broll and Weather Station Pro devices. Please

@MartinHjelmare
Copy link
Member

If you want to suggest an enhancement please open a feature request in the Feature Requests section of our community forum.

Merged PRs should not be used for enhancement discussion or bug reports.

Thanks!

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Jan 22, 2019
@worm-ee worm-ee deleted the homematicip_cloud-update_rest_api_version branch February 3, 2019 09:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants