-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Recollect Waste #20121
Add Recollect Waste #20121
Conversation
…llection date and for which types of waste.
…l. Used different pylint exclusion comment.
I have made the changes suggested by the code reviewers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! Just a few more small items.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! 😎 Can merge when build passes.
… in SCAN_INTERVAL now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Description:
This is a new platform for Recollect Waste. It pulls the data from their site using their API. A place_id and service_id are required for the configuration. More details on how to obtain these can be found at https://github.com/stealthhacker/python-recollect-waste.
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8171
Example entry for
configuration.yaml
(if applicable):This is an example place_id and service_id that can be used.
Configuration variables:
place_id (Required): The place id used by Recollect API.
service_id (Required): The service id used by Recollect API.
name (Optional): The name.
update_interval (Optional): How often to pull from Recollect Waste. Default is 1 day.
Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices: