New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Recollect Waste #20121

Merged
merged 11 commits into from Jan 29, 2019

Conversation

Projects
None yet
5 participants
@stealthhacker
Copy link
Contributor

stealthhacker commented Jan 14, 2019

Description:

This is a new platform for Recollect Waste. It pulls the data from their site using their API. A place_id and service_id are required for the configuration. More details on how to obtain these can be found at https://github.com/stealthhacker/python-recollect-waste.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8171

Example entry for configuration.yaml (if applicable):

This is an example place_id and service_id that can be used.

- platform: recollect_waste
  place_id: 85E562F0-49EC-11E6-A261-153143E100E1
  service_id: 339

Configuration variables:

place_id (Required): The place id used by Recollect API.
service_id (Required): The service id used by Recollect API.
name (Optional): The name.
update_interval (Optional): How often to pull from Recollect Waste. Default is 1 day.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

stealthhacker added some commits Jan 22, 2019

Added true to add_entities. Created constant for default time interva…
…l. Used different pylint exclusion comment.
@stealthhacker

This comment has been minimized.

Copy link
Contributor Author

stealthhacker commented Jan 23, 2019

I have made the changes suggested by the code reviewers.

@bachya
Copy link
Contributor

bachya left a comment

Almost there! Just a few more small items.

Show resolved Hide resolved homeassistant/components/sensor/recollect_waste.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/recollect_waste.py Outdated
@bachya

bachya approved these changes Jan 23, 2019

Copy link
Contributor

bachya left a comment

Great! 😎 Can merge when build passes.

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Nice!

Show resolved Hide resolved homeassistant/components/sensor/recollect_waste.py Outdated

@MartinHjelmare MartinHjelmare changed the title Added Recollect Waste Add Recollect Waste Jan 29, 2019

@MartinHjelmare MartinHjelmare merged commit 6ff4ea1 into home-assistant:dev Jan 29, 2019

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.05%) to 92.994%
Details

@wafflebot wafflebot bot removed the in progress label Jan 29, 2019

@balloob balloob referenced this pull request Feb 6, 2019

Merged

0.87.0 #20794

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment