Handle non-string values in JSON template renderer #20233
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Using the SQL Sensor to extract a datetime value for a state (such as last_changed), and using value_template to convert that datetime to another format, was resulting in a TypeError being thrown by json.loads, indirectly called by async_render_with_possible_json_value in homeassistant.helpers.template. This error should be ignored so that the template can be rendered without value_json (just like what happens with a malformed JSON string.)
This change fixes that problem by catching TypeError in addition to ValueError.
Example error from log:
Related issue (if applicable): none
Pull request in home-assistant.io with documentation (if applicable): none
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf the code does not interact with devices: