Add initial support for Sony SDCP projector control #20269

alistairg · 2019-01-20T17:36:36Z

Description:

Add basic support as a Switch platform for turning on and off Sony projectors via network SDCP control.

Related issue (if applicable): fixes #

Pull request in home-assistant/home-assistant.io#8390

(To be added)

Example entry for `configuration.yaml` (if applicable):

switch:
  - platform: sony_projector
    host: "192.168.1.43"

Checklist:

The code change is tested and works locally.
Local tests pass with tox. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

New dependencies have been added to the REQUIREMENTS variable (example).
New dependencies are only imported inside functions that use them (example).
New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
New files were added to .coveragerc.

If the code does not interact with devices:

Tests have been added to verify that the new code works.

homeassistant/components/switch/sony_projector.py

rohankapoorcom

Don't forget to update requirements_all.txt

homeassistant/components/switch/sony_projector.py

frenck · 2019-01-21T11:34:04Z

⚠️ I was unable to find a documentation PR (matching this code change) in our documentation repository.

📚Please, update the documentation and open a PR for it (be sure to create a documentation PR against the next branch) and link 🔗 this PR and the new documentation PR by mentioning the link to the PR's in both openings posts/descriptions.

🏷 I am adding the docs-missing label until this has been resolved.

👍 Thanks (times a million!)

…into sony-sdcp

- Validation of connection during setup_platform - Docs pending

alistairg · 2019-02-02T18:54:01Z

Docs PR 8390: home-assistant/home-assistant.io#8390

rohankapoorcom

Don't forget to update .coveragerc :).

homeassistant/components/switch/sony_projector.py

rohankapoorcom · 2019-02-03T07:24:49Z

@alistairg can you update the description with the docs PR in the correct place per the template?

Co-Authored-By: alistairg <alistair@alistairs.net>

alistairg · 2019-02-05T00:06:55Z

@rohankapoorcom - Forgive me... is there something I need to do to close this out? As far as I can see it's all good to go, but Git still shows as "changes requested"...

rohankapoorcom · 2019-02-17T20:56:56Z

@rohankapoorcom - Forgive me... is there something I need to do to close this out? As far as I can see it's all good to go, but Git still shows as "changes requested"...

Sorry - I hadn't had a chance to review this again. LGTM.

homeassistant/components/switch/sony_projector.py

rohankapoorcom · 2019-02-19T03:24:06Z

Can be merged when build passes.

MartinHjelmare

Please open a new PR where we can address the comments.

MartinHjelmare · 2019-02-23T22:09:50Z

homeassistant/components/switch/sony_projector.py

+        return self._state
+
+    @property
+    def state_attributes(self):


Use device_state_attributes instead. state_attributes should only be used by the base entity in the base component (switch).

MartinHjelmare · 2019-02-23T22:11:39Z

homeassistant/components/switch/sony_projector.py

+        _LOGGER.debug("Powering on projector '%s'...", self.name)
+        if self._sdcp.set_power(True):
+            _LOGGER.debug("Powered on successfully.")
+            self._state = STATE_ON


We can remove the change of state holding instance attributes. update will be called at the end of the service call, ie after this method is called.

MartinHjelmare · 2019-02-23T22:11:48Z

homeassistant/components/switch/sony_projector.py

+        _LOGGER.debug("Powering off projector '%s'...", self.name)
+        if self._sdcp.set_power(False):
+            _LOGGER.debug("Powered off successfully.")
+            self._state = STATE_OFF


MartinHjelmare · 2019-02-23T22:12:07Z

homeassistant/components/switch/sony_projector.py

+        sdcp_connection.get_power()
+    except ConnectionError:
+        _LOGGER.error("Failed to connect to projector '%s'", host)
+        return False


Nothing is checking this return value. Just return.

MartinHjelmare · 2019-02-23T22:12:12Z

homeassistant/components/switch/sony_projector.py

+        return False
+    _LOGGER.debug("Validated projector '%s' OK", host)
+    add_entities([SonyProjector(sdcp_connection, name)], True)
+    return True


See above. We can remove this statement.

MartinHjelmare · 2019-02-23T22:14:31Z

homeassistant/components/switch/sony_projector.py

+        """Turn the projector on."""
+        _LOGGER.debug("Powering on projector '%s'...", self.name)
+        if self._sdcp.set_power(True):
+            _LOGGER.debug("Powered on successfully.")


We don't end logging messages with period.

Add initial support for Sony SDCP projector control

ba0628d

homeassistant added cla-signed new-platform platform: switch.sony_projector labels Jan 20, 2019

ghost added the in progress label Jan 20, 2019

houndci-bot reviewed Jan 20, 2019

View reviewed changes

homeassistant/components/switch/sony_projector.py Outdated Show resolved Hide resolved

rohankapoorcom requested changes Jan 20, 2019

View reviewed changes

fabaff reviewed Jan 20, 2019

View reviewed changes

homeassistant/components/switch/sony_projector.py Outdated Show resolved Hide resolved

fabaff reviewed Jan 20, 2019

View reviewed changes

homeassistant/components/switch/sony_projector.py Outdated Show resolved Hide resolved

fabaff reviewed Jan 20, 2019

View reviewed changes

homeassistant/components/switch/sony_projector.py Outdated Show resolved Hide resolved

fabaff reviewed Jan 20, 2019

View reviewed changes

homeassistant/components/switch/sony_projector.py Outdated Show resolved Hide resolved

Changes to reflect code review

9dca1ae

frenck added the docs-missing label Jan 21, 2019

alistairg added 3 commits January 23, 2019 07:29

Merge branch 'dev' of https://github.com/home-assistant/home-assistant …

7e92e55

…into sony-sdcp

Merge branch 'dev' of https://github.com/home-assistant/home-assistant …

c4cef01

…into sony-sdcp

Added code per change requests

e13ad55

- Validation of connection during setup_platform - Docs pending

alistairg mentioned this pull request Feb 2, 2019

Add documentation for sony_projector switch component home-assistant/home-assistant.io#8390

Merged

alistairg added 2 commits February 2, 2019 15:30

Removed blank lines per CI build

f0e3d88

Lint fix

b357573

rohankapoorcom requested changes Feb 3, 2019

View reviewed changes

homeassistant/components/switch/sony_projector.py Outdated Show resolved Hide resolved

homeassistant/components/switch/sony_projector.py Outdated Show resolved Hide resolved

homeassistant/components/switch/sony_projector.py Outdated Show resolved Hide resolved

rohankapoorcom removed the docs-missing label Feb 3, 2019

rohankapoorcom and others added 2 commits February 3, 2019 14:34

Update homeassistant/components/switch/sony_projector.py

5ca1de8

Co-Authored-By: alistairg <alistair@alistairs.net>

Updated .coveragerc, made requested logger changes

438a424

rohankapoorcom approved these changes Feb 17, 2019

View reviewed changes

rohankapoorcom reviewed Feb 17, 2019

View reviewed changes

homeassistant/components/switch/sony_projector.py Outdated Show resolved Hide resolved

Update docstring

e759cb0

ghost assigned rohankapoorcom Feb 19, 2019

rohankapoorcom removed their assignment Feb 19, 2019

andrewsayre merged commit 1eba90d into home-assistant:dev Feb 23, 2019

ghost removed the in progress label Feb 23, 2019

MartinHjelmare reviewed Feb 23, 2019

View reviewed changes

alistairg deleted the sony-sdcp branch February 23, 2019 22:18

balloob mentioned this pull request Mar 6, 2019

0.89.0 #21712

Merged

ghost added integration: sony_projector and removed platform: switch.sony_projector labels Mar 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add initial support for Sony SDCP projector control #20269

Add initial support for Sony SDCP projector control #20269

alistairg commented Jan 20, 2019 •

edited by rohankapoorcom

Loading

rohankapoorcom left a comment

frenck commented Jan 21, 2019

alistairg commented Feb 2, 2019

rohankapoorcom left a comment

rohankapoorcom commented Feb 3, 2019

alistairg commented Feb 5, 2019

rohankapoorcom commented Feb 17, 2019

rohankapoorcom commented Feb 19, 2019

MartinHjelmare left a comment

MartinHjelmare Feb 23, 2019

MartinHjelmare Feb 23, 2019

MartinHjelmare Feb 23, 2019

MartinHjelmare Feb 23, 2019

MartinHjelmare Feb 23, 2019

MartinHjelmare Feb 23, 2019

Add initial support for Sony SDCP projector control #20269

Add initial support for Sony SDCP projector control #20269

Conversation

alistairg commented Jan 20, 2019 • edited by rohankapoorcom Loading

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

rohankapoorcom left a comment

Choose a reason for hiding this comment

frenck commented Jan 21, 2019

alistairg commented Feb 2, 2019

rohankapoorcom left a comment

Choose a reason for hiding this comment

rohankapoorcom commented Feb 3, 2019

alistairg commented Feb 5, 2019

rohankapoorcom commented Feb 17, 2019

rohankapoorcom commented Feb 19, 2019

MartinHjelmare left a comment

Choose a reason for hiding this comment

MartinHjelmare Feb 23, 2019

Choose a reason for hiding this comment

MartinHjelmare Feb 23, 2019

Choose a reason for hiding this comment

MartinHjelmare Feb 23, 2019

Choose a reason for hiding this comment

MartinHjelmare Feb 23, 2019

Choose a reason for hiding this comment

MartinHjelmare Feb 23, 2019

Choose a reason for hiding this comment

MartinHjelmare Feb 23, 2019

Choose a reason for hiding this comment

alistairg commented Jan 20, 2019 •

edited by rohankapoorcom

Loading

Example entry for `configuration.yaml` (if applicable):