-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix homematicip cloud alarm_arm_home #20321
Conversation
Hi @coreGreenberet, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
@mxworm do you have time to review? |
Hi, sure. I will review and test tomorrow. Ciao |
Hi @coreGreenberet, |
I guess I've made a mistake while creating the other PR. I can't change anything here anymore. I will change the lib version in the PR #20398 |
Always take for habit to work in separate git feature branches. That way, if one branch is messed up, other branches are not affected. It also simplifies rebasing from upstream if not working locally on the same branch as upstream target branch (dev). |
I will for the next time =) since the api version got implemented in PR #20398, can this be merged too now? |
Hi together, with Beta 0.87.0b0 HmIP Alarm option works better but not perfect. Now I am able to swicth to arm_home but the entity status in HA looks wrong. Switch on Arm_home -> Only Alarm extern shows "Armed_Home" (shoud it not be Alarm internal?) Switch on Arm_way -> Alam external and internal changed to "Armed_away" (should it be not only Alarm external?) Please be so kind to double check, if possible. In addition thank you very much for your hard work. |
Please open an issue if you suspect a bug. If you want to suggest an enhancement please open a feature request in the Feature Requests section of our community forum. Merged PRs should not be used for enhancement discussion or bug reports. If you've found a bug it's ok to make a review with inline comments and link to an issue that reports the bug. Thanks! |
Description:
The parameters were switched, so I've just fixed it with exchanging True,False to False,True
Related issue (if applicable): fixes #20307
Checklist:
tox
. Your PR cannot be merged unless tests passSadly I can't test the code locally, but I'm the maintainer of the api which is getting called in the background and the call to the API was wrong, so I've fixed that.